Skip to content

[Master]-When we run the Order Planning Worksheet by Project, a supply suggestion is created for items that are already received but not invoiced in Purchase Orders, but only after updating Order and Posting Dates on Purchase Order. - #10225

Open
neeleshsinghal wants to merge 1 commit into
mainfrom
bugs/Bug-646661-Order-Planning-by-Project-Not-already-received-but-not-invoiced

Conversation

@neeleshsinghal

@neeleshsinghal neeleshsinghal commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Fixes AB#646661

@neeleshsinghal
neeleshsinghal requested a lite review from Copilot August 13, 2026 09:12
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 13, 2026
@github-actions github-actions Bot added the SCM GitHub request for SCM area label Aug 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an Order Planning (by Project/Job Demand) issue where supply could be re-suggested for Purchase Order quantities that were already received but not invoiced after updating PO Order/Posting Dates.

Changes:

  • Update Job Demand netting to also account for Qty. Rcd. Not Invoiced (Base) when computing remaining needed quantity.
  • Add a regression test covering the “received-not-invoiced after date change” scenario and a confirm handler used by the test run.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/Layers/W1/Tests/SCM-Planning/SCMOrderPlanningI.Codeunit.al Adds a regression test for AB#646661 and introduces a generic confirm handler used by the test.
src/Layers/W1/BaseApp/Inventory/Requisition/GetUnplannedDemand.Codeunit.al Adjusts Job Planning Line needed-qty calculation to net against received-not-invoiced purchase quantities.
Suppressed comments (1)

src/Layers/W1/Tests/SCM-Planning/SCMOrderPlanningI.Codeunit.al:43

  • The ValidationError label contains a double space after %1, which makes assertion messages look malformed.
        ValidationError: Label '%1  must be %2 in %3.';

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/Layers/W1/Tests/SCM-Planning/SCMOrderPlanningI.Codeunit.al
@neeleshsinghal
neeleshsinghal marked this pull request as ready for review August 13, 2026 11:02
@neeleshsinghal
neeleshsinghal requested a review from a team August 13, 2026 11:02
Comment thread src/Layers/W1/Tests/SCM-Planning/SCMOrderPlanningI.Codeunit.al
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants