[Master]-When we run the Order Planning Worksheet by Project, a supply suggestion is created for items that are already received but not invoiced in Purchase Orders, but only after updating Order and Posting Dates on Purchase Order. - #10225
Open
neeleshsinghal wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an Order Planning (by Project/Job Demand) issue where supply could be re-suggested for Purchase Order quantities that were already received but not invoiced after updating PO Order/Posting Dates.
Changes:
- Update Job Demand netting to also account for Qty. Rcd. Not Invoiced (Base) when computing remaining needed quantity.
- Add a regression test covering the “received-not-invoiced after date change” scenario and a confirm handler used by the test run.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Layers/W1/Tests/SCM-Planning/SCMOrderPlanningI.Codeunit.al | Adds a regression test for AB#646661 and introduces a generic confirm handler used by the test. |
| src/Layers/W1/BaseApp/Inventory/Requisition/GetUnplannedDemand.Codeunit.al | Adjusts Job Planning Line needed-qty calculation to net against received-not-invoiced purchase quantities. |
Suppressed comments (1)
src/Layers/W1/Tests/SCM-Planning/SCMOrderPlanningI.Codeunit.al:43
- The ValidationError label contains a double space after %1, which makes assertion messages look malformed.
ValidationError: Label '%1 must be %2 in %3.';
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
neeleshsinghal
requested review from
a team,
Predrag Maricic (PredragMaricic),
alexei-dobriansky and
v-ankitgoyal
August 13, 2026 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AB#646661