Skip to content

Implement business activity code to EU from Italy localization #10233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alexander Yakunin (Alexander-Ya) wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Implement business activity code to EU from Italy localization #10233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
59b2ac4
Implement Business Activity Code from IT to W1
Alexander-Ya Aug 13, 2026
51d8d45
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
Alexander-Ya Aug 13, 2026
083ad87
Propagate changes
Alexander-Ya Aug 13, 2026
47b5a9c
Add missing APAC change
Alexander-Ya Aug 13, 2026
4cd164d
Fix AL0792 unused usings breaking Apps AT build
Copilot Aug 13, 2026
f6def32
Fix compile errors
Alexander-Ya Aug 13, 2026
5bd6b69
Merge branch 'bugs/Implement-Business-Activity-Code-from-IT' of https…
Alexander-Ya Aug 13, 2026
98068b0
Update solution
Alexander-Ya Aug 14, 2026
740803f
Add missing change
Alexander-Ya Aug 15, 2026
84ff489
Fix warnings and errors
Alexander-Ya Aug 15, 2026
6c4f41b
Fix VAT Statement Line
Alexander-Ya Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Layers/APAC/BaseApp/Finance/GeneralLedger/Journal/GenJournalLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2750,6 +2750,11 @@ table 81 "Gen. Journal Line"
Editable = false;
FieldClass = FlowField;
}
field(395; "Business Activity Code"; Code[10])

@github-actions github-actions Bot Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟠\ High\ Severity\ —\ Privacy}$

The PR adds 179 new Normal "Business Activity Code" fields across changed tables/tableextensions without a field-level DataClassification, relying on table scope instead. BCQuality's AS0016 guidance requires every Normal field to declare DataClassification explicitly rather than inheriting it from the table.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.32.4

{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Dimension set identifier linking to dimension value combinations for analytical reporting and cost center tracking.
/// </summary>
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/APAC/BaseApp/Finance/GeneralLedger/Journal/PostedGenJournalLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,11 @@ table 181 "Posted Gen. Journal Line"
Caption = 'Exported to Payment File';
Editable = false;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Dimension set identifier linking posted entries to dimension combinations for analytical reporting and financial analysis.
/// </summary>
Expand Down
4 changes: 4 additions & 0 deletions src/Layers/APAC/BaseApp/Finance/GeneralLedger/Setup/GeneralLedgerSetup.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,6 +1442,10 @@ table 98 "General Ledger Setup"
Caption = 'Use Concurrent Posting';
ToolTip = 'Specifies whether to use concurrent posting when posting journals. Concurrent posting can reduce the time it takes to post journals by allowing multiple batches to be posted at the same time. Enabling this option requires additional configuration and setup, such as setting up a batch job to run the concurrent posting process and ensuring that your system has the necessary resources to support concurrent processing.';
}
field(395; "Use Business Activity Code"; Boolean)

@github-actions github-actions Bot Aug 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟠\ High\ Severity\ —\ Privacy}$

14 changed "General Ledger Setup" table copies (APAC, BE, CH, DACH, ES, FR, GB, IT, NA, NL, NO, RU, SE, W1) add a Normal "Use Business Activity Code" field without field-level DataClassification. Privacy guidance requires every Normal table field to declare DataClassification explicitly.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.33.4

{
Caption = 'Use Business Activity Code';
}
field(11600; "BAS to be Lodged as a Group"; Boolean)
{
Caption = 'BAS to be Lodged as a Group';
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/APAC/BaseApp/Finance/VAT/Ledger/VATEntry.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,6 +774,11 @@ table 254 "VAT Entry"
TableRelation = "G/L Register";
ToolTip = 'Specifies the G/L register number that groups related G/L entries from the same posting.';
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Percentage of VAT that is non-deductible based on business use or regulatory restrictions.
/// </summary>
Expand Down
6 changes: 6 additions & 0 deletions src/Layers/APAC/BaseApp/Foundation/Company/CompanyInformation.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ using Microsoft.EServices.OnlineMap;
using Microsoft.Finance.VAT.Registration;
using Microsoft.Finance.WithholdingTax;
using Microsoft.Foundation.Address;
using Microsoft.Foundation.AuditCodes;
using Microsoft.Foundation.Calendar;
using Microsoft.Foundation.Enums;
using Microsoft.Inventory.Item;
Expand Down Expand Up @@ -471,6 +472,11 @@ table 79 "Company Information"
SetBrandColorValue();
end;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
field(5700; "Responsibility Center"; Code[10])
{
Caption = 'Responsibility Center';
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/APAC/BaseApp/Purchases/Archive/PurchaseHeaderArchive.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,6 +742,11 @@ table 5109 "Purchase Header Archive"
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
ExtendedDatatype = PhoneNo;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
field(480; "Dimension Set ID"; Integer)
{
Caption = 'Dimension Set ID';
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/APAC/BaseApp/Purchases/Document/PurchaseHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2330,6 +2330,11 @@ table 38 "Purchase Header"
FieldClass = FlowField;
AutoFormatType = 1;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
field(480; "Dimension Set ID"; Integer)
{
Caption = 'Dimension Set ID';
Expand Down
6 changes: 6 additions & 0 deletions src/Layers/APAC/BaseApp/Purchases/History/PurchCrMemoHdr.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,12 @@ table 124 "Purch. Cr. Memo Hdr."
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
ExtendedDatatype = PhoneNo;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
Editable = false;
TableRelation = "Business Activity".Code;
}
field(480; "Dimension Set ID"; Integer)
{
Caption = 'Dimension Set ID';
Expand Down
6 changes: 6 additions & 0 deletions src/Layers/APAC/BaseApp/Purchases/History/PurchInvHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,12 @@ table 122 "Purch. Inv. Header"
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
ExtendedDatatype = PhoneNo;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
Editable = false;
TableRelation = "Business Activity".Code;
}
field(480; "Dimension Set ID"; Integer)
{
Caption = 'Dimension Set ID';
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/APAC/BaseApp/Sales/Archive/SalesHeaderArchive.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,6 +1190,11 @@ table 5107 "Sales Header Archive"
ExtendedDatatype = PhoneNo;
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Specifies the unique identifier for the combination of dimension values assigned to this document.
/// </summary>
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/APAC/BaseApp/Sales/Document/SalesHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2937,6 +2937,11 @@ table 36 "Sales Header"
Editable = false;
FieldClass = FlowField;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Specifies the identifier for the combination of dimensions applied to the document.
/// </summary>
Expand Down
6 changes: 6 additions & 0 deletions src/Layers/APAC/BaseApp/Sales/History/SalesCrMemoHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,6 +940,12 @@ table 114 "Sales Cr.Memo Header"
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
ExtendedDatatype = PhoneNo;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
Editable = false;
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Specifies the unique identifier for the dimension set applied to this credit memo.
/// </summary>
Expand Down
6 changes: 6 additions & 0 deletions src/Layers/APAC/BaseApp/Sales/History/SalesInvoiceHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,12 @@ table 112 "Sales Invoice Header"
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
ExtendedDatatype = PhoneNo;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
Editable = false;
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Specifies the unique identifier for the dimension set applied to this document.
/// </summary>
Expand Down
8 changes: 7 additions & 1 deletion src/Layers/AT/BaseApp/Foundation/Company/CompanyInformation.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ using Microsoft.Bank.Setup;
using Microsoft.EServices.OnlineMap;
using Microsoft.Finance.VAT.Registration;
using Microsoft.Foundation.Address;
using Microsoft.Foundation.AuditCodes;
using Microsoft.Foundation.Calendar;
using Microsoft.Foundation.Enums;
using Microsoft.Inventory.Intrastat;
Expand Down Expand Up @@ -474,6 +475,11 @@ table 79 "Company Information"
SetBrandColorValue();
end;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
field(5700; "Responsibility Center"; Code[10])
{
Caption = 'Responsibility Center';
Expand Down Expand Up @@ -1014,4 +1020,4 @@ table 79 "Company Information"
begin
end;

}
}
5 changes: 5 additions & 0 deletions src/Layers/BE/BaseApp/Finance/GeneralLedger/Journal/GenJournalLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2754,6 +2754,11 @@ table 81 "Gen. Journal Line"
Editable = false;
FieldClass = FlowField;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Dimension set identifier linking to dimension value combinations for analytical reporting and cost center tracking.
/// </summary>
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/BE/BaseApp/Finance/GeneralLedger/Journal/PostedGenJournalLine.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,11 @@ table 181 "Posted Gen. Journal Line"
Caption = 'Exported to Payment File';
Editable = false;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Dimension set identifier linking posted entries to dimension combinations for analytical reporting and financial analysis.
/// </summary>
Expand Down
4 changes: 4 additions & 0 deletions src/Layers/BE/BaseApp/Finance/GeneralLedger/Setup/GeneralLedgerSetup.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1444,6 +1444,10 @@ table 98 "General Ledger Setup"
Caption = 'Use Concurrent Posting';
ToolTip = 'Specifies whether to use concurrent posting when posting journals. Concurrent posting can reduce the time it takes to post journals by allowing multiple batches to be posted at the same time. Enabling this option requires additional configuration and setup, such as setting up a batch job to run the concurrent posting process and ensuring that your system has the necessary resources to support concurrent processing.';
}
field(395; "Use Business Activity Code"; Boolean)
{
Caption = 'Use Business Activity Code';
}
field(11315; "VAT Statement Template Name"; Code[10])
{
Caption = 'VAT Statement Template Name';
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/BE/BaseApp/Finance/VAT/Ledger/VATEntry.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,6 +774,11 @@ table 254 "VAT Entry"
TableRelation = "G/L Register";
ToolTip = 'Specifies the G/L register number that groups related G/L entries from the same posting.';
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Percentage of VAT that is non-deductible based on business use or regulatory restrictions.
/// </summary>
Expand Down
1 change: 0 additions & 1 deletion src/Layers/BE/BaseApp/Finance/VAT/Setup/VATSetup.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ page 187 "VAT Setup"
end;
end;


var
IsVATDateEnabled: Boolean;
}
Expand Down
4 changes: 4 additions & 0 deletions src/Layers/BE/BaseApp/Finance/VAT/Setup/VATSetup.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,10 @@ table 189 "VAT Setup"
{
Caption = 'Ship-To Alt. Cust. VAT Reg.';
}
field(395; "Per Business Activity Code Settl. Entry"; Boolean)

@github-actions github-actions Bot Aug 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$\textbf{🟠\ High\ Severity\ —\ Privacy}$

The new "Per Business Activity Code Settl. Entry" field on BE's VATSetup.Table.al is a Normal field added without field-level DataClassification. Privacy guidance requires every Normal table field to declare DataClassification explicitly.

Knowledge:

👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.33.4

{
Caption = 'Per Business Activity Code Settlement Entry';
}
}

keys
Expand Down
6 changes: 6 additions & 0 deletions src/Layers/BE/BaseApp/Foundation/Company/CompanyInformation.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ using Microsoft.Bank.Setup;
using Microsoft.EServices.OnlineMap;
using Microsoft.Finance.VAT.Registration;
using Microsoft.Foundation.Address;
using Microsoft.Foundation.AuditCodes;
using Microsoft.Foundation.Calendar;
using Microsoft.Foundation.Enums;
using Microsoft.Inventory.Item;
Expand Down Expand Up @@ -468,6 +469,11 @@ table 79 "Company Information"
SetBrandColorValue();
end;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
field(5700; "Responsibility Center"; Code[10])
{
Caption = 'Responsibility Center';
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/BE/BaseApp/Purchases/Archive/PurchaseHeaderArchive.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -741,6 +741,11 @@ table 5109 "Purchase Header Archive"
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
ExtendedDatatype = PhoneNo;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
field(480; "Dimension Set ID"; Integer)
{
Caption = 'Dimension Set ID';
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/BE/BaseApp/Purchases/Document/PurchaseHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2324,6 +2324,11 @@ table 38 "Purchase Header"
FieldClass = FlowField;
AutoFormatType = 1;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
field(480; "Dimension Set ID"; Integer)
{
Caption = 'Dimension Set ID';
Expand Down
6 changes: 6 additions & 0 deletions src/Layers/BE/BaseApp/Purchases/History/PurchCrMemoHdr.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,12 @@ table 124 "Purch. Cr. Memo Hdr."
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
ExtendedDatatype = PhoneNo;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
Editable = false;
TableRelation = "Business Activity".Code;
}
field(480; "Dimension Set ID"; Integer)
{
Caption = 'Dimension Set ID';
Expand Down
6 changes: 6 additions & 0 deletions src/Layers/BE/BaseApp/Purchases/History/PurchInvHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,12 @@ table 122 "Purch. Inv. Header"
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
ExtendedDatatype = PhoneNo;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
Editable = false;
TableRelation = "Business Activity".Code;
}
field(480; "Dimension Set ID"; Integer)
{
Caption = 'Dimension Set ID';
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/BE/BaseApp/Sales/Archive/SalesHeaderArchive.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,6 +1189,11 @@ table 5107 "Sales Header Archive"
ExtendedDatatype = PhoneNo;
ToolTip = 'Specifies the telephone number of the company''s shipping address.';
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Specifies the unique identifier for the combination of dimension values assigned to this document.
/// </summary>
Expand Down
5 changes: 5 additions & 0 deletions src/Layers/BE/BaseApp/Sales/Document/SalesHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2935,6 +2935,11 @@ table 36 "Sales Header"
Editable = false;
FieldClass = FlowField;
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Specifies the identifier for the combination of dimensions applied to the document.
/// </summary>
Expand Down
15 changes: 10 additions & 5 deletions src/Layers/BE/BaseApp/Sales/FinanceCharge/FinanceChargeMemoHeader.Table.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,11 @@ table 302 "Finance Charge Memo Header"
ToolTip = 'Specifies the bank account to use for bank information when the document is printed.';
TableRelation = "Bank Account" where("Currency Code" = field("Currency Code"));
}
field(395; "Business Activity Code"; Code[10])
{
Caption = 'Business Activity Code';
TableRelation = "Business Activity".Code;
}
/// <summary>
/// Specifies the unique identifier for the combination of dimension values assigned to this memo.
/// </summary>
Expand Down Expand Up @@ -659,9 +664,9 @@ table 302 "Finance Charge Memo Header"
if "No." = '' then begin
TestNoSeries();
"No. Series" := GetNoSeriesCode();
if NoSeries.AreRelated("No. Series", xRec."No. Series") then
"No. Series" := xRec."No. Series";
"No." := NoSeries.GetNextNo("No. Series", "Posting Date");
if NoSeries.AreRelated("No. Series", xRec."No. Series") then
"No. Series" := xRec."No. Series";
"No." := NoSeries.GetNextNo("No. Series", "Posting Date");

end;
"Posting Description" := StrSubstNo(Text000, "No.");
Expand All @@ -674,8 +679,8 @@ table 302 "Finance Charge Memo Header"
then
"Issuing No. Series" := "No. Series"
else
if NoSeries.IsAutomatic(GetIssuingNoSeriesCode()) then
"Issuing No. Series" := GetIssuingNoSeriesCode();
if NoSeries.IsAutomatic(GetIssuingNoSeriesCode()) then
"Issuing No. Series" := GetIssuingNoSeriesCode();

if "Posting Date" = 0D then
"Posting Date" := WorkDate();
Expand Down
Loading
Loading