Ruleset hardening: promote 6 rules from Warning to Error

src/Apps/W1/EDocumentConnectors/Microsoft365/app/app.json

@@ -7,7 +7,7 @@
   "version": "29.0.0.0",
   "privacyStatement": "https://go.microsoft.com/fwlink/?LinkId=724009",
   "EULA": "https://go.microsoft.com/fwlink/?linkid=2009120",
-  "help": " https://learn.microsoft.com/en-us/dynamics365/business-central/finance-edocuments-overview",
+  "help": "https://learn.microsoft.com/en-us/dynamics365/business-central/finance-edocuments-overview",
   "url": "https://go.microsoft.com/fwlink/?LinkId=724011",
   "logo": "ExtensionLogo.png",
   "contextSensitiveHelpUrl": "https://go.microsoft.com/fwlink/?linkid=2206603",

src/Apps/W1/EDocumentConnectors/Pagero/app/app.json

@@ -7,7 +7,7 @@
   "version": "29.0.0.0",
   "privacyStatement": "https://go.microsoft.com/fwlink/?LinkId=724009",
   "EULA": "https://go.microsoft.com/fwlink/?linkid=2009120",
-  "help": " https://learn.microsoft.com/en-us/dynamics365/business-central/finance-edocuments-overview",
+  "help": "https://learn.microsoft.com/en-us/dynamics365/business-central/finance-edocuments-overview",
   "url": "https://go.microsoft.com/fwlink/?LinkId=724011",
   "logo": "ExtensionLogo.png",
   "contextSensitiveHelpUrl": "https://go.microsoft.com/fwlink/?linkid=2206603",

src/Apps/W1/EmailLogging/app/src/permissions/EmailLoggingObj.PermissionSet.al

@@ -17,6 +17,7 @@ permissionset 1680 "Email Logging - Obj."
                   codeunit "Email Logging API Client" = X,
                   codeunit "Email Logging API Helper" = X,
                   codeunit "Email Logging Message" = X,
+                  codeunit "Email Logging Install" = X,
                   codeunit "Email Logging Upgrade" = X,
                   page "Email Logging Setup" = X,
                   page "Email Logging Setup Wizard" = X,

src/Apps/W1/WithholdingTax/app/src/Employee/History/WHTEmplLedgerEntryExt.TableExt.al

@@ -14,6 +14,7 @@ tableextension 6810 "WHT Empl. Ledger Entry Ext" extends "Employee Ledger Entry"
         {
             Caption = 'Withholding Tax Amount';
             AutoFormatType = 1;
+            AutoFormatExpression = Rec."Currency Code";
             Editable = false;
             DataClassification = CustomerContent;
             ToolTip = 'Specifies the withholding tax amount for the employee ledger entry.';
@@ -22,6 +23,7 @@ tableextension 6810 "WHT Empl. Ledger Entry Ext" extends "Employee Ledger Entry"
         {
             Caption = 'Withholding Tax Base Amount';
             AutoFormatType = 1;
+            AutoFormatExpression = Rec."Currency Code";
             Editable = false;
             DataClassification = CustomerContent;
             ToolTip = 'Specifies the withholding tax base amount for the employee ledger entry.';

src/Apps/W1/WithholdingTax/app/src/Employee/History/WHTThresholdAccumulator.Table.al

@@ -57,12 +57,16 @@ table 6794 "WHT Threshold Accumulator"
         {
             Caption = 'Accumulated Base Amount';
             AutoFormatType = 1;
+            // The accumulator only ever holds local currency amounts.
+            AutoFormatExpression = '';
             ToolTip = 'Specifies the accumulated base amount for the withholding tax threshold accumulator.';
         }
         field(9; "Accumulated WHT Amount"; Decimal)
         {
             Caption = 'Accumulated Withholding Tax Amount';
             AutoFormatType = 1;
+            // The accumulator only ever holds local currency amounts.
+            AutoFormatExpression = '';
             ToolTip = 'Specifies the accumulated withholding tax amount for the withholding tax threshold accumulator.';
         }
     }

src/Apps/W1/WithholdingTax/app/src/Purchase/History/WithholdingTaxEntry.Table.al

@@ -430,6 +430,7 @@ table 6788 "Withholding Tax Entry"
         {
             Caption = 'Taxable Base Amount';
             AutoFormatType = 1;
+            AutoFormatExpression = Rec."Currency Code";
             Editable = false;
         }
         field(28101; "Pymt. Disc. Diff. Base"; Decimal)

src/Layers/APAC/BaseApp/eServices/EDocument/IncomingDocument.Page.al

@@ -1164,10 +1164,12 @@ page 189 "Incoming Document"
         ReplaceMainAttachmentEnabled := Rec.CanReplaceMainAttachment();
     end;
 
+#pragma warning disable AL0547 // Accepted violation: turning off global variable access is a breaking change for existing subscribers of this published event.
     [IntegrationEvent(true, true)]
     local procedure OnCloseIncomingDocumentFromAction(var IncomingDocument: Record "Incoming Document")
     begin
     end;
+#pragma warning restore AL0547
 
     local procedure VerifyCanBeSentToOCR(): Boolean
     begin

src/Layers/ES/BaseApp/Finance/FinancialReports/AccountScheduleNames.Page.al

@@ -155,7 +155,6 @@ page 103 "Account Schedule Names"
             {
                 Caption = 'F&unctions';
                 Image = "Action";
-                Visible = false;
                 action("Export Schedules to ASC format")
                 {
                     ApplicationArea = Basic, Suite;

src/Layers/NL/Tests/TestLibraries/NLXMLReadHelper.Codeunit.al

@@ -46,7 +46,9 @@ codeunit 143001 "NL XML Read Helper"
     var
         Node: DotNet XmlNode;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror GetNodeByElementName(ElementName, Node);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedError('Element is missing!');
     end;
 
@@ -66,7 +68,9 @@ codeunit 143001 "NL XML Read Helper"
     var
         Attribute: DotNet XmlAttribute;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror GetAttributeFromElement(ElementName, AttributeName, Attribute);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedError('Attribute is missing!');
     end;
 

src/Layers/NO/Tests/TestLibraries/NOXMLReadHelper.Codeunit.al

@@ -47,7 +47,9 @@ codeunit 143001 "NO XML Read Helper"
     var
         Node: DotNet XmlNode;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror GetNodeByElementName(ElementName, Node);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedError(StrSubstNo(MissingElementErr, ElementName));
     end;
 
@@ -87,7 +89,9 @@ codeunit 143001 "NO XML Read Helper"
     var
         Attribute: DotNet XmlAttribute;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror GetAttributeFromElement(ElementName, AttributeName, Attribute);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedError('Attribute is missing!');
     end;
 

src/Layers/W1/BaseApp/System/Workflow/WorkflowWebhookNotification.Codeunit.al

@@ -115,12 +115,14 @@ codeunit 1545 "Workflow Webhook Notification"
         end;
     end;
 
+#pragma warning disable AL0547 // Accepted violation: turning off global variable access is a breaking change for existing subscribers of this published event.
     [TryFunction]
     [IntegrationEvent(true, true)]
     [Scope('OnPrem')]
     procedure OnPostNotificationRequest(DataID: Guid; WorkflowStepInstanceID: Guid; NotificationUrl: Text; RequestedByUserEmail: Text)
     begin
     end;
+#pragma warning restore AL0547
 
     [EventSubscriber(ObjectType::Codeunit, Codeunit::"Workflow Webhook Notification", 'OnPostNotificationRequest', '', false, false)]
     [TryFunction]

src/Layers/W1/BaseApp/eServices/EDocument/IncomingDocument.Page.al

@@ -1163,10 +1163,12 @@ page 189 "Incoming Document"
         ReplaceMainAttachmentEnabled := Rec.CanReplaceMainAttachment();
     end;
 
+#pragma warning disable AL0547 // Accepted violation: turning off global variable access is a breaking change for existing subscribers of this published event.
     [IntegrationEvent(true, true)]
     local procedure OnCloseIncomingDocumentFromAction(var IncomingDocument: Record "Incoming Document")
     begin
     end;
+#pragma warning restore AL0547
 
     local procedure VerifyCanBeSentToOCR(): Boolean
     begin

src/Layers/W1/BaseApp/eServices/EDocument/IncomingDocuments.Page.al

@@ -903,10 +903,12 @@ page 190 "Incoming Documents"
         AutomaticCreationActionsAreEnabled := Rec."Data Exchange Type" <> '';
     end;
 
+#pragma warning disable AL0547 // Accepted violation: turning off global variable access is a breaking change for existing subscribers of this published event.
     [IntegrationEvent(true, true)]
     local procedure OnCloseIncomingDocumentsFromActions(var IncomingDocument: Record "Incoming Document")
     begin
     end;
+#pragma warning restore AL0547
 
     local procedure SetProcessedDocumentsVisibility(ShowProcessedItems: Boolean)
     begin

src/Layers/W1/DemoTool/app.json

@@ -4,6 +4,7 @@
   "publisher": "Microsoft",
   "version": "29.0.0.0",
   "platform": "29.0.0.0",
+  "url": "https://go.microsoft.com/fwlink/?LinkId=724011",
   "target": "OnPrem",
   "dependencies": [],
   "resourceExposurePolicy": {

src/Layers/W1/Tests/ApplicationTestLibrary/LibraryAssembly.Codeunit.al

@@ -234,7 +234,9 @@ codeunit 132207 "Library - Assembly"
         if ExpectedError = '' then
             BatchPostAssemblyOrders.RunModal()
         else begin
+            #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
             asserterror BatchPostAssemblyOrders.RunModal();
+            #pragma warning restore AS0058, PTE0007
             Assert.IsTrue(StrPos(GetLastErrorText, ExpectedError) > 0, 'Actual:' + GetLastErrorText);
             ClearLastError();
         end;
@@ -1506,7 +1508,9 @@ codeunit 132207 "Library - Assembly"
         if ExpectedError = '' then
             AssemblyPost.Run(AssemblyHeader)
         else begin
+            #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
             asserterror AssemblyPost.Run(AssemblyHeader);
+            #pragma warning restore AS0058, PTE0007
             Assert.IsTrue(StrPos(GetLastErrorText, ExpectedError) > 0,
               'Expected:' + ExpectedError + '. Actual:' + GetLastErrorText);
             ClearLastError();
@@ -1742,7 +1746,9 @@ codeunit 132207 "Library - Assembly"
         if ExpectedError = '' then
             AsmPostCtrl.Undo(PostedAssemblyHeader, RestoreAO)
         else begin
+            #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
             asserterror AsmPostCtrl.Undo(PostedAssemblyHeader, RestoreAO);
+            #pragma warning restore AS0058, PTE0007
             Assert.IsTrue(StrPos(GetLastErrorText, ExpectedError) > 0, 'Actual:' + GetLastErrorText);
             ClearLastError();
         end;
@@ -1754,7 +1760,9 @@ codeunit 132207 "Library - Assembly"
     begin
         Commit();
         if AssemblyHeader.Quantity = 0 then begin
+            #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
             asserterror AssemblyHeader.UpdateUnitCost();
+            #pragma warning restore AS0058, PTE0007
             Assert.AreEqual(
               StrSubstNo(ErrorZeroQty, AssemblyHeader."No."), GetLastErrorText,
               'Actual:' + GetLastErrorText + '; Expected:' + StrSubstNo(ErrorZeroQty, AssemblyHeader."No."));
@@ -1766,7 +1774,9 @@ codeunit 132207 "Library - Assembly"
         if Item."Costing Method" <> Item."Costing Method"::Standard then
             AssemblyHeader.UpdateUnitCost()
         else begin
+            #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
             asserterror AssemblyHeader.UpdateUnitCost();
+            #pragma warning restore AS0058, PTE0007
             Assert.IsTrue(StrPos(GetLastErrorText, ErrorStdCost) > 0, 'Actual:' + GetLastErrorText + '; Expected:' + ErrorStdCost);
             ClearLastError();
         end;

src/Layers/W1/Tests/ApplicationTestLibrary/app.json

@@ -4,6 +4,7 @@
   "publisher": "Microsoft",
   "version": "29.0.0.0",
   "platform": "29.0.0.0",
+  "url": "https://go.microsoft.com/fwlink/?LinkId=724011",
   "dependencies": [
     {
       "id": "e7320ebb-08b3-4406-b1ec-b4927d3e280b",

src/Layers/W1/Tests/TestLibraries/LibraryCRMIntegration.Codeunit.al

@@ -1919,7 +1919,9 @@ codeunit 139164 "Library - CRM Integration"
         JobQueueEntryID := JobQueueEntry.ID;
         JobQueueEntry.SetStatus(JobQueueEntry.Status::Ready);
         if HandleError then begin
+            #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
             asserterror LibraryJobQueue.RunJobQueueDispatcher(JobQueueEntry);
+            #pragma warning restore AS0058, PTE0007
             LibraryJobQueue.RunJobQueueErrorHandler(JobQueueEntry);
         end else
             LibraryJobQueue.RunJobQueueDispatcher(JobQueueEntry);

src/Layers/W1/Tests/TestLibraries/LibraryJobQueue.Codeunit.al

@@ -71,7 +71,9 @@ codeunit 132458 "Library - Job Queue"
         JobQueueEntry.Status := JobQueueEntry.Status::Ready;
         JobQueueEntry.Modify();
         if WithErrorHandler then begin
+            #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
             asserterror RunJobQueueDispatcher(JobQueueEntry);
+            #pragma warning restore AS0058, PTE0007
             RunJobQueueErrorHandler(JobQueueEntry);
         end
         else

src/Layers/W1/Tests/TestLibraries/LibraryPermissionsVerify.Codeunit.al

@@ -101,7 +101,9 @@ codeunit 132216 "Library - Permissions Verify"
         RecordRef: RecordRef;
     begin
         RecordRef.Open(TableNo);
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror RecordRef.FindFirst();
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedError(StrSubstNo(MissingPermissionErr, Format(RecordRef.Caption)))
     end;
 
@@ -116,10 +118,14 @@ codeunit 132216 "Library - Permissions Verify"
     begin
         RecordRef.Init();
 
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror RecordRef.Insert(true);
+        #pragma warning restore AS0058, PTE0007
         Assert.IsFalse(RecordRef.WritePermission, StrSubstNo(SupplementalPermissionErr, 'Insert', Format(RecordRef.Caption)));
 
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror RecordRef.Delete(true);
+        #pragma warning restore AS0058, PTE0007
         Assert.IsFalse(RecordRef.WritePermission, StrSubstNo(SupplementalPermissionErr, 'Delete', Format(RecordRef.Caption)));
     end;
 }

src/Layers/W1/Tests/TestLibraries/LibraryPostPrevHandler.Codeunit.al

@@ -65,9 +65,13 @@ codeunit 131011 "Library - Post. Prev. Handler"
         InsertRecord(RecVar);
         Assert.IsTrue(GenJnlPostPreview.IsActive(), 'GenJnlPostPreview.IsActive');
         if InvokeCommit then
+            #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
             asserterror Commit()
+            #pragma warning restore AS0058, PTE0007
         else
+            #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
             asserterror GenJnlPostPreview.ThrowError();
+            #pragma warning restore AS0058, PTE0007
         Result := false;
     end;
 }

src/Layers/W1/Tests/TestLibraries/LibraryXMLRead.Codeunit.al

@@ -214,7 +214,9 @@ codeunit 131335 "Library - XML Read"
         [RunOnClient]
         XMLNode: DotNet XmlNode;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror GetNodeByElementName(NodeName, XMLNode);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedErrorCode('Dialog');
         Assert.ExpectedError(StrSubstNo(MissingElementErr, NodeName));
     end;
@@ -224,7 +226,9 @@ codeunit 131335 "Library - XML Read"
         [RunOnClient]
         Node: DotNet XmlNode;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror LocateNodeInSubtree(Node, RootNodeName, NodeName, '', NodeMatchCriteria::FindByName);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedErrorCode('Dialog');
         Assert.ExpectedError(StrSubstNo(NotFoundAnyInSubtreeErr, NodeName, RootNodeName));
     end;
@@ -234,7 +238,9 @@ codeunit 131335 "Library - XML Read"
         [RunOnClient]
         Node: DotNet XmlNode;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror LocateNodeInSubtree(Node, RootNodeName, NodeName, '', NodeMatchCriteria::FindByName);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedErrorCode('Dialog');
         Assert.ExpectedError(StrSubstNo(MissingElementErr, NodeName));
     end;
@@ -261,7 +267,9 @@ codeunit 131335 "Library - XML Read"
 
     procedure VerifyAttributeAbsenceInSubtree(RootNodeName: Text; NodeName: Text; AttributeName: Text)
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror GetAttributeValueInSubtree(RootNodeName, NodeName, AttributeName);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedErrorCode('Dialog');
         Assert.ExpectedError(StrSubstNo(AttributeNotFoundErr, NodeName, RootNodeName, AttributeName));
     end;

src/Layers/W1/Tests/TestLibraries/LibraryXMLReadOnServer.Codeunit.al

@@ -218,7 +218,9 @@ codeunit 131341 "Library - XML Read OnServer"
     var
         XMLNode: DotNet XmlNode;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror GetNodeByElementName(NodeName, XMLNode);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedErrorCode('Dialog');
         Assert.ExpectedError(StrSubstNo(MissingElementErr, NodeName));
     end;
@@ -228,7 +230,9 @@ codeunit 131341 "Library - XML Read OnServer"
     var
         Node: DotNet XmlNode;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror LocateNodeInSubtree(Node, RootNodeName, NodeName, '', NodeMatchCriteria::FindByName);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedErrorCode('Dialog');
         Assert.ExpectedError(StrSubstNo(NotFoundAnyInSubtreeErr, NodeName, RootNodeName));
     end;
@@ -238,7 +242,9 @@ codeunit 131341 "Library - XML Read OnServer"
     var
         Node: DotNet XmlNode;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror LocateNodeInSubtree(Node, RootNodeName, NodeName, '', NodeMatchCriteria::FindByName);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedErrorCode('Dialog');
         Assert.ExpectedError(StrSubstNo(MissingElementErr, NodeName));
     end;
@@ -273,7 +279,9 @@ codeunit 131341 "Library - XML Read OnServer"
     [Scope('OnPrem')]
     procedure VerifyAttributeAbsenceInSubtree(RootNodeName: Text; NodeName: Text; AttributeName: Text)
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror GetAttributeValueInSubtree(RootNodeName, NodeName, AttributeName);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedErrorCode('Dialog');
         Assert.ExpectedError(StrSubstNo(AttributeNotFoundErr, NodeName, RootNodeName, AttributeName));
     end;

src/Layers/W1/Tests/TestLibraries/LibraryXPathXMLReader.Codeunit.al

@@ -227,7 +227,9 @@ codeunit 131337 "Library - XPath XML Reader"
     var
         Node: DotNet XmlNode;
     begin
+        #pragma warning disable AS0058, PTE0007 // Accepted violation: this is a test library helper that intentionally wraps asserterror for use by test codeunits.
         asserterror GetNodeByElementName(ElementName, Node);
+        #pragma warning restore AS0058, PTE0007
         Assert.ExpectedError('Element is missing!');
     end;