Skip to content

Fix Incoming Documents default processed filter #9401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jesper Schulz-Wedde (JesperSchulz) merged 4 commits into from
Aug 17, 2026
Merged

Fix Incoming Documents default processed filter #9401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bf6b8e
Fix incoming documents default filter
Jul 14, 2026
41e45d9
Reuse incoming document visibility helper
Jul 14, 2026
d655a42
Keep filtered incoming document actions usable
Jul 15, 2026
8c5c3d4
Isolate incoming document UI tests
Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Layers/W1/BaseApp/eServices/EDocument/IncomingDocuments.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,8 +800,8 @@ page 190 "Incoming Documents"
UpdateOCRSetupVisibility();

Rec.FilterGroup(0);
if Rec.GetFilter(Processed) <> '' then
SetProcessedDocumentsVisibility(Rec.GetFilter(Processed) = Format(true));
if Rec.GetFilter(Processed) = '' then
Comment thread
JesperSchulz marked this conversation as resolved.
SetProcessedDocumentsVisibility(false);
end;

var
Expand Down Expand Up @@ -937,4 +937,3 @@ page 190 "Incoming Documents"
begin
end;
}

54 changes: 53 additions & 1 deletion src/Layers/W1/Tests/ERM/ERMIncomingDocuments.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1880,6 +1880,30 @@ codeunit 134400 "ERM Incoming Documents"
IncomingDocument.HyperlinkToDocument(DocumentNo, PostingDate);
end;

[Test]
[HandlerFunctions('IncomingDocumentsProcessedFilterHandler')]
[Scope('OnPrem')]
procedure TestIncomingDocsDefaultToUnprocessed()
begin
VerifyIncomingDocumentsProcessedFilter('', false);
end;

[Test]
[HandlerFunctions('IncomingDocumentsProcessedFilterHandler')]
[Scope('OnPrem')]
procedure TestIncomingDocsPreserveProcessedFilter()
begin
VerifyIncomingDocumentsProcessedFilter(Format(true), true);
end;

[Test]
[HandlerFunctions('IncomingDocumentsProcessedFilterHandler')]
[Scope('OnPrem')]
procedure TestIncomingDocsPreserveUnprocessedFilter()
Comment thread
JesperSchulz marked this conversation as resolved.
begin
VerifyIncomingDocumentsProcessedFilter(Format(false), false);
end;

[Test]
[Scope('OnPrem')]
procedure TestIncomingDocsShouldShowAllDocsOnShowAllAction()
Expand Down Expand Up @@ -2181,6 +2205,24 @@ codeunit 134400 "ERM Incoming Documents"
Assert.AreEqual(DataExchangeTypeHasValue, IncomingDocuments.CreateDocument.Enabled(), 'Editable value unexpected.');
end;

local procedure VerifyIncomingDocumentsProcessedFilter(ProcessedFilter: Text; ExpectedProcessed: Boolean)
var
IncomingDocument: Record "Incoming Document";
begin
IncomingDocument.DeleteAll();
CreateIncomingDocument(IncomingDocument, 'Processed Document', true);
CreateIncomingDocument(IncomingDocument, 'Unprocessed Document', false);

IncomingDocument.Reset();
if ProcessedFilter <> '' then
IncomingDocument.SetFilter(Processed, ProcessedFilter);

LibraryVariableStorage.Clear();
LibraryVariableStorage.Enqueue(ExpectedProcessed);
Page.RunModal(Page::"Incoming Documents", IncomingDocument);
LibraryVariableStorage.AssertEmpty();
end;

local procedure GetIncomeStatementAcc(): Code[20]
var
GLAccount: Record "G/L Account";
Expand Down Expand Up @@ -2732,6 +2774,17 @@ codeunit 134400 "ERM Incoming Documents"
IncomingDocuments.OK().Invoke();
end;

[ModalPageHandler]
[Scope('OnPrem')]
procedure IncomingDocumentsProcessedFilterHandler(var IncomingDocuments: TestPage "Incoming Documents")
Comment thread
JesperSchulz marked this conversation as resolved.
begin
IncomingDocuments.Processed.AssertEquals(LibraryVariableStorage.DequeueBoolean());
Assert.IsFalse(IncomingDocuments.Next(), 'Expected the page to contain one incoming document.');
Assert.IsTrue(IncomingDocuments.ShowAll.Enabled(), 'Expected Show All to be enabled for a filtered view.');
Assert.IsFalse(IncomingDocuments.ShowUnprocessed.Enabled(), 'Expected Show Unprocessed to be disabled for a filtered view.');
IncomingDocuments.OK().Invoke();
end;

[PageHandler]
[Scope('OnPrem')]
procedure IncomingDocumentCardHandler(var IncomingDocumentCard: TestPage "Incoming Document")
Expand Down Expand Up @@ -2870,4 +2923,3 @@ codeunit 134400 "ERM Incoming Documents"
Assert.AreEqual(1, TempBlobList.Count(), NoOfAttachmentsSameErr);
end;
}

Loading