621963 Deprecate table 9650 "Custom Report Layout" (Pending, tag 29.0) + country forks #9695
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ using System.Reflection; | |
| /// <summary> | ||
| /// Configures default report selections for compensations. Allows users to specify which reports to use for printing, emailing, and other output operations. | ||
| /// </summary> | ||
| #pragma warning disable AS0032 | ||
|
Contributor
There was a problem hiding this comment. The new AS0032 suppression spans almost the entire page 31282 "Report Selection - Comp. CZC" (lines 13-209) instead of only the obsolete report-selection or custom-layout references it was added for. That object-wide disable will also hide any later unrelated AppSource violation in the same file. Move the disable/restore pair down to the exact CLEAN29-gated lines that still need it. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.31.4 |
||
| page 31282 "Report Selection - Comp. CZC" | ||
| { | ||
| AboutTitle = 'About report selection for compensation'; | ||
|
|
@@ -120,12 +121,16 @@ page 31282 "Report Selection - Comp. CZC" | |
| ToolTip = 'Specifies the ID of the custom email body layout that is used.'; | ||
| Visible = false; | ||
| } | ||
| #if not CLEAN29 | ||
| #pragma warning disable AL0432 | ||
| field("Email Body Layout Description"; Rec."Email Body Layout Description") | ||
| { | ||
| ApplicationArea = Basic, Suite; | ||
| ToolTip = 'Specifies a description of the custom email body layout that is used.'; | ||
| Visible = false; | ||
| } | ||
| #pragma warning restore AL0432 | ||
| #endif | ||
| } | ||
| } | ||
| area(factboxes) | ||
|
|
@@ -201,4 +206,5 @@ page 31282 "Report Selection - Comp. CZC" | |
| begin | ||
| end; | ||
| } | ||
| #pragma warning restore AS0032 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,9 @@ using Microsoft.Purchases.History; | |
| using Microsoft.Purchases.Payables; | ||
| using Microsoft.Purchases.Setup; | ||
| using Microsoft.Purchases.Vendor; | ||
| #if not CLEAN29 | ||
| using Microsoft.Sales.Customer; | ||
| #endif | ||
| using Microsoft.Sales.Document; | ||
| using Microsoft.Sales.History; | ||
| using Microsoft.Service.Document; | ||
|
|
@@ -34,6 +36,7 @@ using System.Environment.Configuration; | |
| using System.TestLibraries.Utilities; | ||
| using System.Utilities; | ||
|
|
||
| #pragma warning disable AL0432, AS0105 | ||
|
Contributor
There was a problem hiding this comment. The new AS0105 suppression spans almost the entire codeunit 139515 "Digital Vouchers Tests" (lines 37-2060) instead of only the obsolete-table references introduced by this cleanup. Keeping the AppSource rule disabled at object scope will hide future unrelated AppSource violations anywhere in the file. Narrow the disable/restore pair to the exact obsolete declarations or calls that still require it. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.31.4 |
||
| codeunit 139515 "Digital Vouchers Tests" | ||
| { | ||
| Subtype = Test; | ||
|
|
@@ -53,8 +56,12 @@ codeunit 139515 "Digital Vouchers Tests" | |
| LibraryRandom: Codeunit "Library - Random"; | ||
| LibraryLowerPermissions: Codeunit "Library - Lower Permissions"; | ||
| Assert: Codeunit Assert; | ||
| #if not CLEAN29 | ||
| LibraryEmail: Codeunit "Library - Email"; | ||
| #endif | ||
| #if not CLEAN29 | ||
| ActiveDirectoryMockEvents: Codeunit "Active Directory Mock Events"; | ||
| #endif | ||
| LibrarySmallBusiness: Codeunit "Library - Small Business"; | ||
| LibraryService: Codeunit "Library - Service"; | ||
| IsInitialized: Boolean; | ||
|
|
@@ -494,6 +501,7 @@ codeunit 139515 "Digital Vouchers Tests" | |
| UnbindSubscription(DigVouchersDisableEnforce); | ||
| end; | ||
|
|
||
| #if not CLEAN29 | ||
| [Test] | ||
| [HandlerFunctions('StrMenuHandler,VerifyNoAttachmentsInEmailEditorModalPageHandler')] | ||
| procedure PostSalesDocAndSendEmailWithDigitalVoucherAutomaticallyGenerated() | ||
|
|
@@ -534,6 +542,7 @@ codeunit 139515 "Digital Vouchers Tests" | |
|
|
||
| UnbindSubscription(DigVouchersDisableEnforce); | ||
| end; | ||
| #endif | ||
|
|
||
| [Test] | ||
| procedure PostMultipleGeneralJournalLinesWithGenerateAutomaticallyOption() | ||
|
|
@@ -1949,6 +1958,7 @@ codeunit 139515 "Digital Vouchers Tests" | |
| LibraryERM.FindVendorLedgerEntry(VendorLedgerEntry, VendorLedgerEntry."Document Type"::Invoice, DocNo); | ||
| end; | ||
|
|
||
| #if not CLEAN29 | ||
| local procedure PrepareSalesShipmentReportSelectionsForEmailBodyWithoutAttachment() | ||
| var | ||
| ReportSelections: Record "Report Selections"; | ||
|
|
@@ -1957,7 +1967,9 @@ codeunit 139515 "Digital Vouchers Tests" | |
| ReportSelections.ModifyAll("Use for Email Body", false); | ||
| ReportSelections.ModifyAll("Use for Email Attachment", false); | ||
| end; | ||
| #endif | ||
|
|
||
| #if not CLEAN29 | ||
| local procedure CreateCustomReportSelectionForCustomer(CustomerNo: Code[20]; ReportSelectionUsage: Enum "Report Selection Usage"; ReportID: Integer) | ||
| var | ||
| CustomReportSelection: Record "Custom Report Selection"; | ||
|
|
@@ -1975,14 +1987,17 @@ codeunit 139515 "Digital Vouchers Tests" | |
| "Email Body Layout Code", CustomReportLayout.InitBuiltInLayout(CustomReportSelection."Report ID", CustomReportLayout.Type::Word.AsInteger())); | ||
| CustomReportSelection.Insert(true); | ||
| end; | ||
| #endif | ||
|
|
||
| #if not CLEAN29 | ||
| local procedure BindActiveDirectoryMockEvents() | ||
| begin | ||
| if ActiveDirectoryMockEvents.Enabled() then | ||
| exit; | ||
| BindSubscription(ActiveDirectoryMockEvents); | ||
| ActiveDirectoryMockEvents.Enable(); | ||
| end; | ||
| #endif | ||
|
|
||
| local procedure CreateBankAccReconciliationLine(BankAccReconciliation: Record "Bank Acc. Reconciliation"; var BankAccReconciliationLine: Record "Bank Acc. Reconciliation Line"; AccountType: Enum "Gen. Journal Account Type"; AccountNo: Code[20]; Amount: Decimal; Date: Date) | ||
| begin | ||
|
|
@@ -2056,3 +2071,4 @@ codeunit 139515 "Digital Vouchers Tests" | |
| TestEmailEditor.Attachments.FileName.AssertEquals(''); | ||
| end; | ||
| } | ||
| #pragma warning restore AL0432, AS0105 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,9 +12,12 @@ using Microsoft.Sales.History; | |
| using Microsoft.Sustainability.Account; | ||
| using Microsoft.Sustainability.Setup; | ||
| using Microsoft.Test.Sustainability; | ||
| #if not CLEAN29 | ||
| using System.Reflection; | ||
| using System.Utilities; | ||
| #endif | ||
|
|
||
| #pragma warning disable AL0432, AS0105 | ||
|
Contributor
There was a problem hiding this comment. The new AS0105 suppression spans almost the entire codeunit 148217 "Sustainability Report Tests" (lines 18-481) instead of only the obsolete-table references introduced by this cleanup. Keeping the AppSource rule disabled at object scope will hide future unrelated AppSource violations anywhere in the file. Narrow the disable/restore pair to the exact obsolete declarations or calls that still require it. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.31.4 |
||
| codeunit 148217 "Sustainability Report Tests" | ||
| { | ||
| Subtype = Test; | ||
|
|
@@ -33,9 +36,11 @@ codeunit 148217 "Sustainability Report Tests" | |
| AccountCodeLbl: Label 'AccountCode%1', Comment = '%1 = Number'; | ||
| CategoryCodeLbl: Label 'CategoryCode%1', Comment = '%1 = Number'; | ||
| SubcategoryCodeLbl: Label 'SubcategoryCode%1', Comment = '%1 = Number'; | ||
| #if not CLEAN29 | ||
| MSXLbl: Label 'MSX%1', Comment = '%1 = random number for unique layout code'; | ||
| MSXILbl: Label 'MSXI%1', Comment = '%1 = random number for unique layout code'; | ||
| DocxLbl: Label 'docx'; | ||
| #endif | ||
| TotalCO2eLbl: Label 'TotalCO2e'; | ||
| CO2ePerUnitLineLbl: Label 'CO2ePerUnit_Line'; | ||
| DisclaimerLbl: Label 'Disclaimer_Lbl'; | ||
|
|
@@ -53,7 +58,9 @@ codeunit 148217 "Sustainability Report Tests" | |
| UnitOfMeasure: Record "Unit of Measure"; | ||
| SalesHeader: Record "Sales Header"; | ||
| SalesLine: Record "Sales Line"; | ||
| #if not CLEAN29 | ||
| CustomReportLayout: Record "Custom Report Layout"; | ||
| #endif | ||
| ExpectedCO2ePerUnit: Decimal; | ||
| ExpectedTotalCO2e: Decimal; | ||
| ExpectedFormatCO2ePerUnit: Text; | ||
|
|
@@ -72,8 +79,10 @@ codeunit 148217 "Sustainability Report Tests" | |
| // [GIVEN] Update "Emission Unit of Measure Code" in Sustainability Setup. | ||
| UpdateEmissionUnitOfMeasureInSustainabilitySetup(UnitOfMeasure.Code); | ||
|
|
||
| #if not CLEAN29 | ||
| // [GIVEN] Select layout as Custom Body Layout in "Standard Sales-Quote" report. | ||
| GetCustomBodyLayout(CustomReportLayout, GetStandardSalesQuoteReportID()); | ||
| #endif | ||
|
|
||
| // [GIVEN] Generate Random CO2e per Unit. | ||
| ExpectedCO2ePerUnit := LibraryRandom.RandDec(20, 2); | ||
|
|
@@ -117,7 +126,9 @@ codeunit 148217 "Sustainability Report Tests" | |
| UnitOfMeasure: Record "Unit of Measure"; | ||
| SalesHeader: Record "Sales Header"; | ||
| SalesLine: Record "Sales Line"; | ||
| #if not CLEAN29 | ||
| CustomReportLayout: Record "Custom Report Layout"; | ||
| #endif | ||
| ExpectedCO2ePerUnitCaption: Text; | ||
| ExpectedTotalCO2eCaption: Text; | ||
| begin | ||
|
|
@@ -133,8 +144,10 @@ codeunit 148217 "Sustainability Report Tests" | |
| // [GIVEN] Update "Emission Unit of Measure Code" in Sustainability Setup. | ||
| UpdateEmissionUnitOfMeasureInSustainabilitySetup(UnitOfMeasure.Code); | ||
|
|
||
| #if not CLEAN29 | ||
| // [GIVEN] Select layout as Custom Body Layout in "Standard Sales-Quote" report. | ||
| GetCustomBodyLayout(CustomReportLayout, GetStandardSalesQuoteReportID()); | ||
| #endif | ||
|
|
||
| // [GIVEN] Create a Sales Quote. | ||
| CreateSalesQuote(SalesHeader, SalesLine); | ||
|
|
@@ -161,7 +174,9 @@ codeunit 148217 "Sustainability Report Tests" | |
| var | ||
| SustainabilitySetup: Record "Sustainability Setup"; | ||
| UnitOfMeasure: Record "Unit of Measure"; | ||
| #if not CLEAN29 | ||
| CustomReportLayout: Record "Custom Report Layout"; | ||
| #endif | ||
| SalesInvoiceHeader: Record "Sales Invoice Header"; | ||
| Quantity: Decimal; | ||
| ExpectedCO2ePerUnit: Decimal; | ||
|
|
@@ -182,8 +197,10 @@ codeunit 148217 "Sustainability Report Tests" | |
| // [GIVEN] Update "Emission Unit of Measure Code" in Sustainability Setup. | ||
| UpdateEmissionUnitOfMeasureInSustainabilitySetup(UnitOfMeasure.Code); | ||
|
|
||
| #if not CLEAN29 | ||
| // [GIVEN] Select layout as Custom Body Layout in "Standard Sales-Invoice" report. | ||
| GetCustomBodyLayout(CustomReportLayout, GetStandardSalesInvoiceReportID()); | ||
| #endif | ||
|
|
||
| // [GIVEN] Generate Random CO2e per Unit and Quantity. | ||
| ExpectedCO2ePerUnit := LibraryRandom.RandDec(20, 2); | ||
|
|
@@ -224,7 +241,9 @@ codeunit 148217 "Sustainability Report Tests" | |
| procedure VerifyCO2ePerUnitAndTotalCO2eCaptionInStandardSalesInvoice() | ||
| var | ||
| UnitOfMeasure: Record "Unit of Measure"; | ||
| #if not CLEAN29 | ||
| CustomReportLayout: Record "Custom Report Layout"; | ||
| #endif | ||
| SalesInvoiceHeader: Record "Sales Invoice Header"; | ||
| Quantity: Decimal; | ||
| ExpectedCO2ePerUnit: Decimal; | ||
|
|
@@ -243,8 +262,10 @@ codeunit 148217 "Sustainability Report Tests" | |
| // [GIVEN] Update "Emission Unit of Measure Code" in Sustainability Setup. | ||
| UpdateEmissionUnitOfMeasureInSustainabilitySetup(UnitOfMeasure.Code); | ||
|
|
||
| #if not CLEAN29 | ||
| // [GIVEN] Select layout as Custom Body Layout in "Standard Sales-Invoice" report. | ||
| GetCustomBodyLayout(CustomReportLayout, GetStandardSalesInvoiceReportID()); | ||
| #endif | ||
|
|
||
| // [GIVEN] Generate Random CO2e per Unit and Quantity. | ||
| ExpectedCO2ePerUnit := LibraryRandom.RandDec(20, 2); | ||
|
|
@@ -301,6 +322,7 @@ codeunit 148217 "Sustainability Report Tests" | |
| LibraryTestInitialize.OnAfterTestSuiteInitialize(Codeunit::"Sustainability Report Tests"); | ||
| end; | ||
|
|
||
| #if not CLEAN29 | ||
| local procedure GetCustomBodyLayout(var CustomReportLayout: Record "Custom Report Layout"; ReportID: Integer) | ||
| var | ||
| ReportLayoutList: Record "Report Layout List"; | ||
|
|
@@ -333,6 +355,7 @@ codeunit 148217 "Sustainability Report Tests" | |
| CopyStream(OutStr, InStr); | ||
| CustomReportLayout.Insert(); | ||
| end; | ||
| #endif | ||
|
|
||
| local procedure CreateSustainabilityCategory(var CategoryCode: Code[20]; i: Integer) | ||
| begin | ||
|
|
@@ -425,6 +448,7 @@ codeunit 148217 "Sustainability Report Tests" | |
| SustainabilityDisclaimer.Insert(); | ||
| end; | ||
|
|
||
| #if not CLEAN29 | ||
| local procedure GetStandardSalesQuoteReportID(): Integer | ||
| begin | ||
| exit(Report::"Standard Sales - Quote"); | ||
|
|
@@ -434,6 +458,7 @@ codeunit 148217 "Sustainability Report Tests" | |
| begin | ||
| exit(Report::"Standard Sales - Invoice"); | ||
| end; | ||
| #endif | ||
|
|
||
| local procedure RunStandardSalesQuoteReport(QuoteNo: Code[20]) | ||
| var | ||
|
|
@@ -476,4 +501,5 @@ codeunit 148217 "Sustainability Report Tests" | |
| begin | ||
| StandardSalesInvoice.SaveAsXml(LibraryReportDataset.GetParametersFileName(), LibraryReportDataset.GetFileName()); | ||
| end; | ||
| } | ||
| #pragma warning restore AL0432, AS0105 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new AS0032 suppression spans almost the entire page 31222 "Report Sel. - Cash Desk CZP" (lines 13-217) instead of only the obsolete report-selection or custom-layout references it was added for. That object-wide disable will also hide any later unrelated AppSource violation in the same file. Move the disable/restore pair down to the exact CLEAN29-gated lines that still need it.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.31.4