Keep AdditionalProperties on every Responses output message

[PratikDhanave (PratikDhanave)]

Summary

In the non-streaming Responses path (provider/openaiprovider/responses.go), when a response has more than one output message, currentUpdate is reset to a fresh &agent.ResponseUpdate{} for each message after the first. The per-message block then repopulates MessageID, ResponseID, FinishReason, ContinuationToken, RawRepresentation, Role, and CreatedAt — but not AdditionalProperties. So the second and later messages lose response-level properties such as EndUserId (from resp.User); only the first message (initialized at the top) and the aggregated response-level merge retain them.

Fix

Repopulate currentUpdate.AdditionalProperties = responsesPopulateAdditionalProperties(resp) in the per-message block, so every output message carries the response-level properties.

Public API

No exported symbols change.

Tests

Adds TestResponses_NonStreaming_AllMessagesKeepAdditionalProperties: a response with two output messages and a response-level "user". The second message's update reports an empty EndUserId before this change and the correct value after. (The existing EndUserId coverage only checked the aggregated resp.AdditionalProperties, which the response-level merge kept populated from the first message — masking the per-message drop.)

go test ./provider/openaiprovider passes; gofmt clean.

[Copilot]

Pull request overview

This PR fixes a correctness issue in the OpenAI Responses non-streaming processing path where response-level AdditionalProperties (e.g., EndUserId derived from resp.User) were dropped for the 2nd and later output messages due to currentUpdate being reset between messages.

Changes:

• Repopulates currentUpdate.AdditionalProperties for each output message in the non-streaming Responses path.
• Adds a regression test covering multi-message non-streaming responses to ensure every message update retains response-level properties.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
provider/openaiprovider/responses.go	Ensures per-message ResponseUpdates retain response-level AdditionalProperties even after currentUpdate is reset between messages.
provider/openaiprovider/responses_additionalprops_test.go	Adds a regression test asserting EndUserId is present on all message-bearing updates for a multi-message response.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[PratikDhanave (PratikDhanave)]

Both review points are addressed: the tests were moved into responses_test.go, and AdditionalProperties is now repopulated only in the per-message reset block (the first message keeps its initialized value, per the Copilot note). Rebased onto the latest main and green. Ready for another look whenever you have a moment — thanks!

[PratikDhanave (PratikDhanave)]

Quim Muntal (@qmuntal) this one is ready for another look — both review points are addressed: the tests were moved into responses_test.go, and the AdditionalProperties repopulation was moved into the message-reset block so it only runs on a message transition (the first message keeps its initialized value). Functional CI is green. Thanks!

[Quim Muntal (qmuntal)]

Thanks! Needs rebase.

[github-actions]

Parity Review — PR #510

Scope: provider/openaiprovider/responses.go (bug fix, 2 files changed)

Verdict: ✅ No parity issues. The parity-approved label is retained.

Summary

This PR fixes a bug in the Go-only non-streaming OpenAI Responses path where currentUpdate.AdditionalProperties was not repopulated when iterating over multiple output messages, causing the second and later messages to silently lose response-level properties (e.g. EndUserId).

• No exported symbols change. The fix is entirely within unexported provider-internal logic.
• No new public API surface is introduced, so the public-api-change label is not warranted.
• Cross-repo consistency: AdditionalProperties propagation on per-message updates is a Go-specific mapping layer over the OpenAI Responses API wire format. The upstream Python and .NET implementations do not have a direct equivalent for this multi-message iteration pattern; this is Go-internal bookkeeping with no parity obligation.
• The added test (TestResponses_NonStreaming_AllMessagesKeepAdditionalProperties) correctly exercises the previously uncovered code path.

No upstream Python or .NET changes are needed.

Generated by Go API Consistency Review Agent · sonnet46 · 14.5 AIC · ⌖ 5.71 AIC · ⊞ 6K · ◷