Preserve large-integer precision when decoding tool arguments by PratikDhanave · Pull Request #528 · microsoft/agent-framework-go

PratikDhanave (PratikDhanave) · 2026-07-17T18:48:02Z

Summary

applySchema (agent/format/jsonformat/encoding.go), reached via Format.Unmarshal, decodes incoming JSON arguments into an interface{} with json.Unmarshal, which turns every JSON number into a float64. Integer arguments beyond 2^53 are therefore silently truncated before being re-marshalled and handed to the typed handler:

// handler takes struct{ N int64 `json:"n"` }
tool.Call(ctx, `{"n":9007199254740993}`)   // 2^53 + 1
// handler receives N == 9007199254740992  (off by one) — no error

Every functool call with an int64/uint64 argument is affected. (The output / Normalize path is not — it operates on the already-typed value and doesn't round-trip through this number-losing step.)

Fix

Decode with json.Decoder + UseNumber(), so numbers are preserved as json.Number and round-trip exactly through the re-marshal.

Public API

No exported symbols change.

Tests

Adds TestFormat_Unmarshal_PreservesLargeIntegerPrecision (black-box): a 2^53+1 argument. It comes back as 9007199254740992 before this change and exactly 9007199254740993 after. Full ./agent/format/jsonformat and ./tool/functool suites pass (no regression).

Copilot

Pull request overview

This PR fixes loss of integer precision (> 2^53) when decoding tool-call JSON arguments by switching the schema-application step to decode numbers as json.Number instead of float64, ensuring large int64/uint64 arguments round-trip correctly into typed handlers.

Changes:

Update applySchema to decode JSON with json.Decoder + UseNumber() to preserve large integer precision.
Add a black-box regression test proving Format.Unmarshal preserves a 2^53+1 integer.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
agent/format/jsonformat/encoding.go	Switch argument decoding to `UseNumber()` in the schema/defaults path to avoid float64 truncation.
agent/format/jsonformat/encoding_test.go	Add regression test ensuring `Unmarshal` preserves large `int64` values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

PratikDhanave (PratikDhanave) · 2026-07-22T04:16:16Z

+		// Decode with UseNumber so integers beyond 2^53 are not silently
+		// truncated by being decoded into float64 and re-marshalled.
+		dec := json.NewDecoder(bytes.NewReader(data))
+		dec.UseNumber()
+		if err := dec.Decode(&v); err != nil {
 			return nil, fmt.Errorf("unmarshaling arguments: %w", err)
 		}
 	}


Addressed — after Decode the code checks for io.EOF and rejects trailing data, restoring json.Unmarshal's strictness.

PratikDhanave (PratikDhanave) · 2026-07-18T15:08:39Z

 import (
+	"bytes"
 	"encoding/json"
 	"fmt"



Done — added the io import and a strict trailing-data check (dec.Token() must return io.EOF). Note: validate() can't also use UseNumber — json.Number is a string type the jsonschema validator rejects as a non-integer, which broke every test; left as a comment in the PR.

PratikDhanave (PratikDhanave) · 2026-07-22T04:16:18Z

+		// Decode with UseNumber so integers beyond 2^53 are not silently
+		// truncated by being decoded into float64 and re-marshalled.
+		dec := json.NewDecoder(bytes.NewReader(data))
+		dec.UseNumber()
+		if err := dec.Decode(&v); err != nil {


The UseNumber decode preserves large-integer precision in the result value the tool receives. validate() re-decodes separately only for schema checking (pre-existing behavior) — json.Number is a string kind the jsonschema validator rejects as non-integer, so it can't be used there. The precision fix applies where it matters (the decoded result) without altering validation.

applySchema decoded incoming JSON arguments into an interface{} via json.Unmarshal, which turns every JSON number into a float64. Integer arguments beyond 2^53 (int64/uint64) were therefore silently truncated before being re-marshalled and handed to the typed handler — e.g. a tool called with {"n":9007199254740993} received 9007199254740992. Decode with json.Decoder.UseNumber() so numbers are preserved as json.Number and round-trip exactly. Only the input path (Format.Unmarshal) was affected; the output/Normalize path already operates on the typed value. Adds a black-box test asserting a 2^53+1 argument round-trips exactly.

Address review feedback: switching to json.Decoder for UseNumber made applySchema tolerate trailing data after the first JSON value, unlike the json.Unmarshal it replaced. Restore strict single-value parsing by requiring io.EOF after the decoded value, and add a regression test. (The related suggestion to also decode with UseNumber inside validate() is not applied: json.Number is a string type that the jsonschema validator rejects as a non-integer, so it cannot be used there.)

github-actions · 2026-08-22T04:38:03Z

Parity Review — ✅ No Issues

This PR changes only the unexported applySchema function in agent/format/jsonformat/encoding.go. No exported Go symbols are added, removed, or modified.

Cross-repo alignment: The fix restores correct integer semantics that .NET and Python already exhibit naturally. Both the .NET System.Text.Json and Python json libraries preserve integer types when deserializing JSON numbers into typed fields, so tool handlers in those SDKs never silently lose precision on int64/uint64 arguments. The Go change brings behavior into alignment by using json.Decoder + UseNumber() instead of json.Unmarshal (which maps every JSON number to float64).

Labels: No exported API surface changed, so public-api-change is not warranted. parity-approved is retained — the change closes a Go-only precision gap and does not introduce any new divergence from .NET or Python.

Generated by Go API Consistency Review Agent · sonnet46 · 13.3 AIC · ⌖ 4.69 AIC · ⊞ 6K · ◷

PratikDhanave (PratikDhanave) requested a review from a team as a code owner July 17, 2026 18:48

Copilot AI review requested due to automatic review settings July 17, 2026 18:48

Copilot started reviewing on behalf of PratikDhanave (PratikDhanave) July 17, 2026 18:48 View session

Copilot AI reviewed Jul 17, 2026

View reviewed changes

PratikDhanave (PratikDhanave) force-pushed the fix-jsonformat-int-precision branch 2 times, most recently from 22af497 to f7805b6 Compare July 23, 2026 15:44