-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Python: Add tool concurrency groups and sequential execution order for same-message calls #7523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pratik wayase (PratikWayase)
wants to merge
5
commits into
microsoft:main
Choose a base branch
from
PratikWayase:feat/serialize-same-message-function-calls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+228
−52
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f233b4c
feat(core): add tool concurrency groups and sequential execution order
PratikWayase e65d39e
fix: address copilot review feedback for tool execution order
PratikWayase 38030f6
fix: resolve concurrency groups and CI fails
PratikWayase fa2c44c
Merge branch 'main' into feat/serialize-same-message-function-calls
PratikWayase 199d2ff
fix(core): keep tool_execution_order in config to prevent nested agen…
PratikWayase File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please keep
tool_execution_orderout ofadditional_function_arguments?Agent.as_tool()forwardsFunctionInvocationContext.kwargsinto the nested agent'sfunction_invocation_kwargs, and_execute_function_callsgives that value precedence over the nested agent's own configuration. An outer run explicitly usingparallelcan therefore override a nested agent configured forsequential, causing its stateful tools to race; filtering this internal key or carrying it only inconfigwould preserve the nested boundary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the code to keep
tool_execution_orderstrictly within the run-level config instead. It's now extracted from options and merged into a copy ofself. function_invocation_configurationand passes only viaconfigparameter to_execute _function_call