.NET: Fix snake_case argument names in Harness file tool descriptions - #7731
Merged
westey (westey-m) merged 2 commits intoAug 18, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: westey-m <164392973+westey-m@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix harness file tool descriptions for argument naming consistency
.NET: Fix snake_case argument names in Harness file tool descriptions
Aug 18, 2026
westey (westey-m)
marked this pull request as ready for review
August 18, 2026 16:56
westey (westey-m)
requested review from
SergeyMenshykh and
Roger Barreto (rogerbarreto)
as code owners
August 18, 2026 16:56
westey (westey-m)
temporarily deployed
to
github-app-auth
August 18, 2026 16:56 — with
GitHub Actions
Inactive
westey (westey-m)
approved these changes
Aug 18, 2026
SergeyMenshykh
approved these changes
Aug 18, 2026
Roger Barreto (rogerbarreto)
approved these changes
Aug 18, 2026
Peter Ibekwe (peibekwe)
approved these changes
Aug 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
AIFunctionFactorygenerates tool schemas from C# parameter names (camelCase), but several[Description]attributes onFileAccessProvider/FileMemoryProvidertools referred to those arguments using snake_case names. A model following the description would emit an argument name the schema doesn't recognize, so the value silently fails to bind and the tool runs without it (e.g., a missing filter) instead of surfacing an error.Description & Review Guide
[Description]text onfile_access_ls/file_memory_lsto sayglobPatterninstead ofglob_pattern.[Description]text onfile_memory_grepto sayglobPatterninstead ofglob_pattern(thefile_access_grepdescription already used "glob pattern" generically and needed no change).[Description]text onfile_access_replace/file_memory_replaceto sayoldString,newString,replaceAllinstead ofold_string,new_string,replace_all.replace_lines'sline_number/new_lineuntouched — those parameters carry explicit[JsonPropertyName]attributes, so the schema genuinely uses snake_case there and the existing description is correct.Related Issue
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.