fix(azure): single-chunk text stream misclassified as tool-call response#7422
Open
alvinttang wants to merge 1 commit intomicrosoft:mainfrom
Open
fix(azure): single-chunk text stream misclassified as tool-call response#7422alvinttang wants to merge 1 commit intomicrosoft:mainfrom
alvinttang wants to merge 1 commit intomicrosoft:mainfrom
Conversation
The Azure AI client's `create_stream()` uses `len(content_deltas) > 1` to decide whether the response is text or tool calls. When a model returns a short answer that fits in a single streaming chunk, `content_deltas` has exactly 1 element, causing the check to fail. The code then falls through to return an empty tool-call list as content and misassigns the actual text to the `thought` field. Rewrite the branching to match the OpenAI client: check `full_tool_calls` first (tool-call response), else treat as text. Add a regression test that streams a single-chunk text reply and asserts it comes back as string content. Closes microsoft#7157 (partial — addresses a separate bug in the same streaming path)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AzureAIChatCompletionClient.create_stream()useslen(content_deltas) > 1to distinguish text responses from tool-call responses. When a model returns a short answer in a single streaming chunk,content_deltashas exactly 1 element, the> 1check fails, and the code falls through to return an empty tool-call list[]as content — silently discarding the actual text (or misassigning it tothought).if full_tool_calls:first, else treat as text content.CreateResult.Root cause
Test plan
test_azure_ai_chat_completion_client_create_stream_single_chunk— mocks a single-chunk text stream, assertsCreateResult.contentis a string (not an empty list)