fix(agentchat): prevent livelock in SelectorGroupChat fallback when allow_repeated_speaker=False#7472
Open
1Ckpwee wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
…ated_speaker=False When max_selector_attempts is exhausted and allow_repeated_speaker=False, the fallback incorrectly returns the previous speaker, creating an infinite loop. Now falls back to a random non-previous participant instead. Fixes microsoft#7471
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SelectorGroupChatwhere the fallback after exhaustingmax_selector_attemptsreturnsself._previous_speakereven whenallow_repeated_speaker=False, causing an infinite loop (A speaks -> selector fails to pick non-A -> falls back to A -> repeat)allow_repeated_speaker=Falseand selector attempts are exhausted, the fallback now picks a random participant that is NOT the previous speakerallow_repeated_speaker=Truefor the case that tests fallback-to-previous behaviortest_selector_group_chat_no_livelock_on_fallback_when_repeated_speaker_disallowedto verify the fixFixes #7471
Test plan
test_selector_group_chat_fall_back_to_previous_after_3_attemptscontinues to pass (now explicitly usesallow_repeated_speaker=True)allow_repeated_speaker=Falseand the LLM exhausts all attempts by picking the previous speaker, the fallback selects a different participant🤖 Generated with Claude Code