Fix append last message in a_run_chat before termination check (#3561)#7489
Open
wrenevens wants to merge 2 commits intomicrosoft:0.2from
Open
Fix append last message in a_run_chat before termination check (#3561)#7489wrenevens wants to merge 2 commits intomicrosoft:0.2from
wrenevens wants to merge 2 commits intomicrosoft:0.2from
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When using
a_initiate_chatwith a GroupChat of multiple agents,the last agent's message was missing from the response history.
Root cause: in
a_run_chat, the termination check happened BEFOREbroadcasting the message to all agents, causing the loop to exit
before the last message was appended to chat history.
The sync
run_chatdoes not have this issue.Changes made to bring
a_run_chatin line with syncrun_chat:self._last_speaker = speakerwhich was missing in asyncNoEligibleSpeakerexception handling missing in asyncRelated issue number
Closes #3561
Checks