fix: add explicit encoding='utf-8' to text file operations#7499
Open
GopalGB wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: add explicit encoding='utf-8' to text file operations#7499GopalGB wants to merge 1 commit intomicrosoft:mainfrom
GopalGB wants to merge 1 commit intomicrosoft:mainfrom
Conversation
On non-English Windows systems, Python's open() defaults to the system locale encoding (e.g. cp1252, gbk) rather than UTF-8, causing UnicodeDecodeError when reading config files, logs, or templates containing non-ASCII characters. Adds encoding='utf-8' to all open() calls across magentic-one-cli, autogen-studio, and agbench packages. Fixes microsoft#5566
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding="utf-8"to allopen()calls for text files acrossmagentic-one-cli,autogen-studio, andagbenchpackagesUnicodeDecodeErroron non-English Windows systems where Python defaults to the system locale encoding (e.g., cp1252, gbk)open()calls fixedFiles Changed
magentic-one-cli/src/magentic_one_cli/_m1.py— config file readsautogen-studio/autogenstudio/database/schema_manager.py— Alembic config/template reads and writesagbench/src/agbench/run_cmd.py— scenario files, env configs, run scriptsagbench/src/agbench/tabulate_cmd.py— console log readsagbench/src/agbench/remove_missing_cmd.py— console log readsagbench/src/agbench/linter/cli.py— log file readsagbench/src/agbench/linter/coders/oai_coder.py— cache file reads/writesTest Plan
encoding="utf-8"parameter onlyFixes #5566