Skip to content

#5545 - Split core eBPF and network extension tests - #5575

Open
VINOD KLSWAMY (kumarvin123) wants to merge 38 commits into
mainfrom
user/vinodko/Convert-to-sampleext
Open

VINOD KLSWAMY (kumarvin123) wants to merge 38 commits into
mainfrom
user/vinodko/Convert-to-sampleext

Conversation

@kumarvin123

Copy link
Copy Markdown
Contributor

Description

Describe the purpose of and changes within this Pull Request.
Splits the Unit tests and driver tests to remove the dependency on netebpfext so that they can be run independently.

Please reference an issue with a keyword such as Fixes #abc, Closes #xyz, etc., so the work can be tracked.
Fixes #5545

Testing

Ran the Tests manually and will watch the CI/CD pipeline to succeed
Do any existing tests cover this change? Are new tests needed?
Yes
If new tests were added:

  • Unit tests are added.
  • Driver tests are added.
  • Fuzz tests are added.

Documentation

Is there any documentation impact for this change?
None

Installation

Is there any installer impact for this change?
No

This comment was marked as resolved.

This comment was marked as resolved.

Copilot AI review requested due to automatic review settings September 25, 2026 23:20

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as duplicate.

Comment thread tests/api_test/api_test.cpp Resolved
Move bpf_get_process_start_key_* and bpf_get_thread_start_time_* test
cases (and their helpers send_traffic, try_get_process_start_key,
run_process_start_key_test, run_thread_start_time_test) from api_test.cpp
to netebpfext_load_test.cpp, since they use CGROUP_INET4/6_CONNECT
hooks that require netebpfext.

Move perform_socket_bind from api_test_jit.cpp/h to socket_helper.h/cpp
so it is available as a shared test utility to both api_test and
netebpfext tests.

Addresses review comments:
- bpf_get_process_start_key/bpf_get_thread_start_time tests moved to
  netebpf-related tests
- perform_socket_bind moved to netebpf test utility (socket_helper)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This comment was marked as duplicate.

This comment was marked as duplicate.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - but there will be more changes to ensure any remaining tests that need to be moved to sample extension is done.
Tracked by #5704

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split core eBPF and network extension tests.

6 participants