docs(testing): align validation guide with current frameworks - #520
docs(testing): align validation guide with current frameworks#520omribz156 wants to merge 7 commits into
Conversation
|
@microsoft-github-policy-service agree |
Chris Montazer (rezatnoMsirhC)
left a comment
There was a problem hiding this comment.
Thank you for cleaning up this guide and replacing the stale Terratest examples with native terraform test guidance.
The PR description does not follow .github/PULL_REQUEST_TEMPLATE.md. Please update it to use the required sections: Description, Related Issue (with Fixes #144), Type of Change, Implementation Details, Testing Performed, Validation Steps, Checklist, and Security Review.
|
Thanks, that makes sense. I updated the PR description to follow No code/docs diff changed in this follow-up; only the PR body was updated. This follow-up was Codex-assisted, with the final text reviewed before posting. |
Marcel Bindseil (bindsi)
left a comment
There was a problem hiding this comment.
🤖 Automated review: Documentation update replacing stale Terratest references with native terraform test guidance. Content aligns with the repo's actual test patterns (command=plan, tests/ directory, setup modules). No functional issues found.
Katrien De Graeve (katriendg)
left a comment
There was a problem hiding this comment.
omribz156 please update the PR to revert/preserve the blueprint testing section (keep the Go/Terratest content and the full-single-node-cluster/tests/ + 904-test-utilities/ references) while keeping all the component-level native-test improvements. Once the blueprint section is preserved, we can approve and merge.
This change is on us, the issue was outdated but has a new section for you to take into account. Please let us know if you are able to take it, or would prefer one of us to pick it up.
Thank you!
b2b687d to
8eb7c25
Compare
|
Thanks, fixed in I restored the Blueprint Testing section to preserve the Go/Terratest guidance, Verified with:
|
Marcel Bindseil (bindsi)
left a comment
There was a problem hiding this comment.
Approved: the blueprint testing concern is addressed while preserving native component testing guidance. No actionable issues found.
Chris Montazer (rezatnoMsirhC)
left a comment
There was a problem hiding this comment.
Thank you for your contribution and for the patience you have shown through this review process. I apologize for the slow turnaround and will check in on your next follow-up sooner.
Katrien De Graeve (katriendg)
left a comment
There was a problem hiding this comment.
omribz156 thank you so much for addressing all changes. As there was no new request for review, I believe I missed everything had been addressed.
Looks good to me, we just require one markdown fix, can you please run npm run format-tables to fix a table alignment issue, which will cause CI to fail.
Thanks!
📚 Documentation Health ReportGenerated on: 2026-09-01 13:59:29 UTC 📈 Documentation Statistics
🏗️ Three-Tree Architecture Status
🔍 Quality Metrics
This report is automatically generated by the Documentation Automation workflow. |
Pull Request
Description
Updates
docs/contributing/testing-validation.mdso the testing guide reflects the current repository layout and tooling. The previous guide still referenced Terratest /go testexamples, while the repo now uses native Terraform.tftest.hcltests, Rust crate tests, and Docusaurus docs checks.Related Issue
Fixes #144
Type of Change
Implementation Details
go testguidance with nativeterraform testexamples..tftest.hcllayout undersrc/000-cloud/000-resource-group/terraform/tests/.cargo testguidance.Testing Performed
Validation Steps
Reviewers can validate this documentation-only change with:
Checklist
terraform fmton all Terraform codeterraform validateon all Terraform codeaz bicep formaton all Bicep codeaz bicep buildto validate all Bicep codeSecurity Review
Additional Notes
This was prepared with Codex assistance, with the final diff reviewed before opening.
Screenshots (if applicable)
N/A; documentation-only change.