Fix scalar temporal union SQL rewrite#5606
Closed
mikaelweave wants to merge 4 commits into
Closed
Conversation
Handle top-level temporal union expressions when splitting SQL search parameter table expressions, and add chained birthdate regression coverage for SQL Server. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mikaelweave
added
Bug
Keep top-level union predicates as normal search parameter table expressions so existing split logic handles aggregate UNION ALL generation without changing SmartV2 stats traversal. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5606 +/- ##
=======================================
Coverage 76.94% 76.94%
=======================================
Files 997 997
Lines 36587 36603 +16
Branches 5526 5530 +4
=======================================
+ Hits 28152 28166 +14
Misses 7086 7086
- Partials 1349 1351 +2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#195104
Summary
Patient.birthdateequality throughMedicationDispenseandMedicationRequestreferences.UnionExpressionpredicates in SQL search-param table splitting/counting.Test Plan
dotnet test .\src\Microsoft.Health.Fhir.SqlServer.UnitTests\Microsoft.Health.Fhir.SqlServer.UnitTests.csproj --filter "FullyQualifiedName=Microsoft.Health.Fhir.SqlServer.UnitTests.Features.Search.Expressions.SearchParamTableExpressionExtensionsTests.GivenSearchParamTableExpressionWithTopLevelUnion_WhenSplitExpressions_ThenUnionIsReturned" --no-restore --nologodotnet build .\test\Microsoft.Health.Fhir.R4.Tests.E2E\Microsoft.Health.Fhir.R4.Tests.E2E.csproj --no-restore --nologo /p:NETCoreSdkVersion=9.0.314dotnet build .\test\Microsoft.Health.Fhir.R4B.Tests.E2E\Microsoft.Health.Fhir.R4B.Tests.E2E.csproj --no-restore --nologo /p:NETCoreSdkVersion=9.0.314dotnet build .\test\Microsoft.Health.Fhir.R5.Tests.E2E\Microsoft.Health.Fhir.R5.Tests.E2E.csproj --no-restore --nologo /p:NETCoreSdkVersion=9.0.314dotnet build .\test\Microsoft.Health.Fhir.Stu3.Tests.E2E\Microsoft.Health.Fhir.Stu3.Tests.E2E.csproj --no-restore --nologo /p:NETCoreSdkVersion=9.0.314Note: local E2E execution hung in this environment, so PR CI is the runtime E2E source of truth.
Related mitigation: PCR #195104.