Fix incorrect default values and parameter name in hubs template docs#2086
Merged
Fix incorrect default values and parameter name in hubs template docs#2086
Conversation
The documentation incorrectly listed the default value for enableRecommendations as True, but the Bicep template defines it as false. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
microsoft-github-policy-service
bot
added
the
Needs: Review 👀
- dataExplorerSkuName default was E2a_v4, but Bicep uses D11_v2 - dataExplorerLogRetentionInDays referenced *_log tables, but the actual parameter is dataExplorerRawRetentionInDays referencing *_raw tables Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
RolandKrummenacher
changed the title
flanakin
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three documentation errors in the FinOps hubs template parameter table (
docs-mslearn/toolkit/hubs/template.md):enableRecommendations: Default listed asTrue, but Bicep template definesfalsedataExplorerSkuName: Default listed asDev(No SLA)_Standard_E2a_v4, but Bicep template usesDev(No SLA)_Standard_D11_v2dataExplorerLogRetentionInDays: Parameter name and description referenced*_logtables, but the actual Bicep parameter isdataExplorerRawRetentionInDaysreferencing*_rawtablesVerified that
createUiDefinition.jsonandDeploy-Hub.ps1are consistent with the Bicep defaults — the errors were only in the docs.Test plan
main.bicepandmodules/hub.bicepcreateUiDefinition.jsondefaults are consistent🤖 Generated with Claude Code