Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a patch to automatically synchronize the configured vector store size with the actual output dimensions of the selected embedding model. This helps prevent mismatches between the embedding model's output and the vector store configuration, improving reliability and reducing manual configuration errors.
Configuration validation and synchronization improvements:
validate_config_names(invalidate_config.py) to detect the actual embedding dimension from the embedding model and updateparameters.vector_store.vector_sizeand all index schemas if there is a mismatch. This ensures the vector store configuration always matches the embedding model output._sync_vector_store_dimensionsto encapsulate the synchronization logic, with appropriate logging and safety checks.Type checking and code clarity:
TYPE_CHECKINGimport forLLMEmbeddingResponseto improve type safety and clarity in the codebase.