Skip to content

fix(skills): minimize Copilot telemetry intrinsic content - #2848

Merged
Bill Berry (WilliamBerryiii) merged 2 commits into
mainfrom
fix/2845-telemetry-doc-runtime-evidence
Sep 9, 2026
Merged

fix(skills): minimize Copilot telemetry intrinsic content#2848
Bill Berry (WilliamBerryiii) merged 2 commits into
mainfrom
fix/2845-telemetry-doc-runtime-evidence

Conversation

@WilliamBerryiii

Copy link
Copy Markdown
Member

Description

Applied intrinsic-content minimization to the local, Azure fleet, and
agent-host relay OpenTelemetry Collector configurations.

  • Normalized nonmatching span names, metric descriptions, and metric units to
    [redacted] while preserving the invoke_agent.* span-name family and
    metric names required by shipped consumers.
  • Derived the protected span-name matcher set from shipped dashboard queries
    and added semantic regression tests for missing or consumer-breaking scrub
    rules.
  • Updated runtime carrier expectations, the skill security model, and
    verification guidance to reflect behavior confirmed through OTLP/HTTP.

Related Issue(s)

Fixes #2845

Type of Change

Select all that apply:

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Infrastructure & Configuration:

  • GitHub Actions workflow
  • Linting configuration (markdown, PowerShell, etc.)
  • Security configuration
  • DevContainer configuration
  • Dependency update

AI Artifacts:

  • Reviewed contribution with hve-builder and addressed all actionable findings
  • Copilot instructions (.github/instructions/*.instructions.md)
  • Copilot prompt (.github/prompts/*.prompt.md)
  • Copilot agent (.github/agents/*.agent.md)
  • Copilot skill (.github/skills/*/SKILL.md)
  • Copilot hook (.github/hooks/*/*.json)
  • Eval spec added/updated for changed AI artifacts (evals/)

Note for AI Artifact Contributors:

  • Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.
  • Skills: Must include both bash and PowerShell scripts. See Skills.
  • Model Versions: Contributions MUST target models listed in the model catalog (scripts/linting/model-catalog.json) whose provider appears in providerAllowlist and whose status is ga or preview. Run npm run lint:models to validate references.
  • See Agents Not Accepted and Model Version Requirements.

Other:

  • Script/automation (.ps1, .sh, .py)
  • Other (please describe):

Sample Prompts (for AI Artifact Contributions)

User Request:

Execution Flow:

Output Artifacts:

Success Indicators:

For detailed contribution requirements, see:

Testing

  • Passed 130 static skill tests with uv run --frozen pytest -m "not slow" -q.
  • Passed 134 runtime carrier tests with
    uv run --frozen pytest -m slow tests/test_collector_carriers.py -q.
  • Passed Ruff checking and formatting validation.
  • Passed validation for all 77 Python-backed skills.
  • Passed npm run validate:docs, including ESLint, type checking, 84 Jest
    tests, and 11 Mermaid tests.
  • Passed npm run spell-check across 796 files.
  • Passed branch-scoped link validation with zero broken links across 1,190
    Markdown files and 2,735 checked links.
  • npm run validate:local completed all preceding lanes but failed in its
    repository-wide link lane on 17 unchanged files.
  • npm run lint:md-links remained non-blocking for this branch because the
    failures were outside the nine-file diff; its changed-file mode passed.
  • No manual testing was performed.

Checklist

Required Checks

  • Documentation is updated (if applicable)
  • Files follow existing naming conventions
  • Changes are backwards compatible (if applicable)
  • Tests added for new functionality (if applicable)

AI Artifact Contributions

  • Used hve-builder review mode to review contribution
  • Addressed all actionable findings from the hve-builder review
  • Verified contribution follows common standards and type-specific requirements

Required Local Checks

The following local-safe validation commands must pass before merging:

  • Local validation aggregate: npm run validate:local
  • Documentation validation (if docs changed): npm run validate:docs
  • Spell checking: npm run spell-check
  • Link validation: npm run lint:md-links

Security Considerations

  • This PR does not contain any sensitive or NDA information
  • Any new dependencies have been reviewed for security issues (N/A - no dependency changes)
  • Security-related scripts follow the principle of least privilege (N/A - no security script changes)

Additional Notes

Runtime confirmation covered the pinned OTLP/HTTP path. OTLP/gRPC and deployed
Azure behavior remained explicitly unverified.

The full-repository link lane reported failures in 17 unchanged files. The
branch-scoped run passed with zero broken links, so those failures were not
caused by this PR.

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.98%. Comparing base (401d61b) to head (72002b3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2848      +/-   ##
==========================================
- Coverage   83.00%   82.98%   -0.02%     
==========================================
  Files         185      173      -12     
  Lines       34924    34456     -468     
  Branches      228        0     -228     
==========================================
- Hits        28989    28594     -395     
- Misses       5861     5862       +1     
+ Partials       74        0      -74     
Flag Coverage Δ
docusaurus ?
pester 83.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Eval Execution

Status: Passed

  • Artifacts evaluated: 0
  • Specs run: 0
  • Assertions passed: 0
  • Assertions failed (blocking): 0
  • Assertions failed (advisory): 0
  • Failed specs (merge-blocking): 0

No changed AI artifacts required evaluation.

@WilliamBerryiii
Bill Berry (WilliamBerryiii) merged commit 9f172da into main Sep 9, 2026
121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align telemetry documentation with confirmed carrier behavior

4 participants