Skip to content

fix(workflows): run static telemetry tests for config changes - #2850

Open
Bill Berry (WilliamBerryiii) wants to merge 1 commit into
mainfrom
fix/2849-azure-static-test-selection
Open

fix(workflows): run static telemetry tests for config changes#2850
Bill Berry (WilliamBerryiii) wants to merge 1 commit into
mainfrom
fix/2849-azure-static-test-selection

Conversation

@WilliamBerryiii

Copy link
Copy Markdown
Member

Description

Updated the generic pytest matrix so the Copilot OTel metrics project runs its non-slow suite when committed IaC, Collector, Compose, dashboard, dependency, or managed-settings inputs change. Other Python projects retain the reusable workflow's Python-only default.

Added focused workflow contracts for the telemetry-only condition, representative included and excluded paths, and the unchanged strict runtime lane. Added nearby workflow comments explaining the conditional override and empty fallback.

Related Issue(s)

Fixes #2849

Type of Change

Select all that apply:

Code & Documentation:

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Infrastructure & Configuration:

  • GitHub Actions workflow
  • Linting configuration (markdown, PowerShell, etc.)
  • Security configuration
  • DevContainer configuration
  • Dependency update

AI Artifacts:

  • Reviewed contribution with hve-builder and addressed all actionable findings
  • Copilot instructions (.github/instructions/*.instructions.md)
  • Copilot prompt (.github/prompts/*.prompt.md)
  • Copilot agent (.github/agents/*.agent.md)
  • Copilot skill (.github/skills/*/SKILL.md)
  • Copilot hook (.github/hooks/*/*.json)
  • Eval spec added/updated for changed AI artifacts (evals/)

Note for AI Artifact Contributors:

  • Agents: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review .github/agents/ before creating new ones.
  • Skills: Must include both bash and PowerShell scripts. See Skills.
  • Model Versions: Contributions MUST target models listed in the model catalog (scripts/linting/model-catalog.json) whose provider appears in providerAllowlist and whose status is ga or preview. Run npm run lint:models to validate references.
  • See Agents Not Accepted and Model Version Requirements.

Other:

  • Script/automation (.ps1, .sh, .py)
  • Other (please describe):

Sample Prompts (for AI Artifact Contributions)

User Request:

Execution Flow:

Output Artifacts:

Success Indicators:

For detailed contribution requirements, see:

Testing

  • npm run test:ps -- -TestPath scripts/tests/extension/Workflow-PackagingContracts.Tests.ps1: passed, 211 tests
  • npm run lint:yaml -- -ChangedFilesOnly -BaseBranch origin/main: passed for one changed workflow
  • npm run lint:ps -- -ChangedFilesOnly -BaseBranch origin/main: passed for one changed PowerShell file
  • Non-link local validation components: passed except repository-wide Python discovery, which entered ignored tracking worktrees; this change contains no Python files
  • npm run validate:docs: passed
  • npm run spell-check: passed
  • git diff --check: passed before commit
  • Link validation: skipped by user direction
  • Manual testing was not performed

Checklist

Required Checks

  • Documentation is updated (N/A - no documentation changed)
  • Files follow existing naming conventions
  • Changes are backwards compatible
  • Tests added for new functionality

AI Artifact Contributions

  • Used hve-builder review mode to review contribution
  • Addressed all actionable findings from the hve-builder review
  • Verified contribution follows common standards and type-specific requirements

Required Local Checks

The following local-safe validation commands must pass before merging:

  • Local validation aggregate: npm run validate:local (not complete: link checks skipped and Python discovery entered ignored worktrees)
  • Documentation validation (if docs changed): npm run validate:docs
  • Spell checking: npm run spell-check
  • Link validation: npm run lint:md-links (skipped by user direction)

Security Considerations

  • This PR does not contain any sensitive or NDA information
  • Any new dependencies have been reviewed for security issues (N/A - no dependencies changed)
  • Security-related scripts follow the principle of least privilege (N/A - no security scripts changed)

Additional Notes

The change updates static PR selection only. It does not alter workflow permissions, the reusable pytest workflow, or the separate container-backed runtime lane. Hosted pull-request execution remains the downstream selector validation.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Eval Execution

⚠️ No eval summary was produced.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.24%. Comparing base (bb0ac58) to head (12733ec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
+ Coverage   83.14%   83.24%   +0.09%     
==========================================
  Files         183      172      -11     
  Lines       34039    34350     +311     
  Branches       27        0      -27     
==========================================
+ Hits        28302    28594     +292     
- Misses       5734     5756      +22     
+ Partials        3        0       -3     
Flag Coverage Δ
docusaurus ?
pester 84.24% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Azure template static tests for IaC and collector configuration changes

2 participants