typescript: allow mixed types for anyOf#6816
typescript: allow mixed types for anyOf#6816danaelhe wants to merge 7 commits intomicrosoft:mainfrom
anyOf#6816Conversation
show service level agreement |
|
@danaelhe Thanks for the contribution! I think you got really close with the agreement. Try
|
Thanks so much!! Just double checking with legal on our side. |
@microsoft-github-policy-service agree company="digitalocean" |
all good now! |
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Can you also add a changelog entry (unreleased, changed)
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
Head branch was pushed to by a user without write access
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
|
@danaelhe there are a number of languages integration tests that are failing. |
|
@danaelhe integration tests are still failing because of the union types. Would you mind having a look please? |
|
@danaelhe gentle reminder on the previous comment |
Described the bug here:
#6801 (comment)
Now it can properly handle anyOf (e.g. here) of mixed types.
Example OpenAPI 3.0 spec:
Now generates:
When before it was just allowing one type:
bySsh_key_identifier(ssh_key_identifier: number) : WithSsh_key_identifierItemRequestBuilder;Re-ran our mocked tests and it all seems to pass...doesn't seem to have broke anything else 🤞