Skip to content

Optimize WHEA UEFI shell test#893

Merged
kuqin12 merged 3 commits into
microsoft:release/202511from
kuqin12:shallow_whea
Jun 8, 2026
Merged

Optimize WHEA UEFI shell test#893
kuqin12 merged 3 commits into
microsoft:release/202511from
kuqin12:shallow_whea

Conversation

@kuqin12

@kuqin12 kuqin12 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Description

The WHEA UEFI shell test currently can take up to 16 minutes to run for AArch64 platforms. 2 main reasons are:

  1. The system does not support variable cache, which requires environment switching for each variable query;
  2. Each WHEA tests will invoke a variable sweep cleanup, that spans from HwErrRec0000 to HwErrRecFFFF;

This PR aims at fixing the latter issue. Given the test will sequentially populate the telemetry entries, the cleanup can also be optimized to, after the first deep clean, stop at the first EFI_NOT_FOUND.

The change created a common routine to centralize all clean up functions and added a new shallow cleanup routine. By adopting shallow cleanups, the tests reduce the original 10 deep cleans down to 2, which should shorten the corresponding test time by 75% ~ 80%.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This test is run on ARM virt platform and confirmed only 2 full cleanups and shortened to local runs to < 2min. All tests are still passing.

Integration Instructions

N/A

@mu-automation

mu-automation Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

✅ QEMU Validation Passed

Source Dependencies

Repository Commit
mu_plus ae38413
mu_tiano_platforms f584806

Results

Platform Target Build Boot Overall Boot Time Build Logs Boot Logs
Q35 DEBUG ✅ success ✅ success 0m 15s Build Logs Boot Logs
SBSA DEBUG ✅ success ✅ success 0m 30s Build Logs Boot Logs

Workflow run: https://github.com/microsoft/mu_plus/actions/runs/27084483584

This comment was automatically generated by the Mu QEMU PR Validation workflow.

@mu-automation mu-automation Bot added the impact:testing Affects testing label Jun 6, 2026
@codecov-commenter

codecov-commenter commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/202511@f72b73c). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/202511    #893   +/-   ##
================================================
  Coverage                  ?   7.37%           
================================================
  Files                     ?      21           
  Lines                     ?    3051           
  Branches                  ?     121           
================================================
  Hits                      ?     225           
  Misses                    ?    2825           
  Partials                  ?       1           
Flag Coverage Δ
MsWheaPkg 7.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuqin12 kuqin12 merged commit f7c042a into microsoft:release/202511 Jun 8, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact:testing Affects testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants