Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions tests/async/test_page_network_response.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,34 @@ def handle_get(request: TestServerRequest) -> None:
error = exc_info.value
assert "closed" in error.message

async def test_response_finished_should_not_leave_page_close_waiter(
page: Page, server: Server
) -> None:
def response_finished_waiters() -> list[asyncio.Task]:
return [
task
for task in asyncio.all_tasks()
if not task.done()
and getattr(task.get_coro(), "__qualname__", "")
== "Response.finished.<locals>.on_finished"
]

baseline = set(response_finished_waiters())
leaked_waiters = []
try:
response = await page.goto(server.EMPTY_PAGE)
assert response
await response.finished()
await asyncio.sleep(0)

leaked_waiters = [
task for task in response_finished_waiters() if task not in baseline
]
assert not leaked_waiters, "Response.finished() leaked page-close waiter tasks"
finally:
await page.close()
if leaked_waiters:
await asyncio.gather(*leaked_waiters, return_exceptions=True)

async def test_should_return_http_version(page: Page, server: Server) -> None:
response = await page.goto(server.EMPTY_PAGE)
Expand Down