Skip to content

fix: handle ignore_default_args=False in launch params #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skn0tt merged 1 commit into from
Apr 30, 2026
+18 −0
Merged

fix: handle ignore_default_args=False in launch params #3058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions playwright/_impl/_browser_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,8 @@ def normalize_launch_params(params: Dict) -> None:
if params["ignoreDefaultArgs"] is True:
params["ignoreAllDefaultArgs"] = True
del params["ignoreDefaultArgs"]
elif params["ignoreDefaultArgs"] is False:
del params["ignoreDefaultArgs"]
if "executablePath" in params:
params["executablePath"] = str(Path(params["executablePath"]))
if "downloadsPath" in params:
Expand Down
9 changes: 9 additions & 0 deletions tests/async/test_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,12 @@ async def test_browser_close_should_be_callable_twice(
browser.close(),
)
await browser.close()


async def test_browser_type_launch_should_accept_ignore_default_args_false(
browser_type: BrowserType, launch_arguments: Dict
) -> None:
# Regression for https://github.com/microsoft/playwright-python/issues/3005:
# passing False used to crash with "expected array, got boolean".
browser = await browser_type.launch(**launch_arguments, ignore_default_args=False)
await browser.close()
7 changes: 7 additions & 0 deletions tests/sync/test_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,10 @@ def test_browser_close_should_be_callable_twice(
browser = browser_type.launch(**launch_arguments)
browser.close()
browser.close()


def test_browser_type_launch_should_accept_ignore_default_args_false(
browser_type: BrowserType, launch_arguments: Dict
) -> None:
browser = browser_type.launch(**launch_arguments, ignore_default_args=False)
browser.close()
Loading