Repository navigation
chore: start v8 profiler from bootstrap via PW_PROFILE_DIR - #43054
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoOct 1, 2026
Merged
Conversation
- bootstrap.ts starts the V8 CPU profiler when PW_PROFILE_DIR is set and writes <script>[-<command>]-<pid>.cpuprofile on exit. - Replaces PWTEST_PROFILE_DIR and the per-process profiling in the test runner, workers and run-server connections. - All process.exit calls go through processExit() from bootstrap, which exits once the profile is written; processExit is lint-restricted like process.exit. - coreBundle loads bootstrap as an external module instead of bundling a second copy; CLI entry points, including cli-client, load it first.
Yury Semikhatsky (yury-s)
approved these changes
Oct 1, 2026
Contributor
Test results for "tests 1"5 flaky52502 passed, 1270 skipped Merge workflow run. |
Contributor
Test results for "MCP"8937 passed, 1489 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bootstrap.tsstarts the V8 CPU profiler whenPW_PROFILE_DIRis set; profiles are named from node args (<script>[-<command>]-<pid>.cpuprofile). ReplacesPWTEST_PROFILE_DIR.process.exitcalls go throughprocessExit()from bootstrap, which exits once the profile is written;processExitis lint-restricted likeprocess.exit.