Skip to content

chore(extension): typecheck extension as part of lint - #43072

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:fix-43050
Oct 2, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:fix-43050

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Summary

  • npm run tsc (and so lint/flint) now also runs the two packages/extension tsconfigs, which the root tsconfig excludes.
  • Fix the existing extension type errors after the @types/chrome bump: TabChangeInfo -> OnUpdatedInfo, and ungroupTabs() passes a non-empty tuple.

Fixes #43050

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:160 › should work with Shift-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/tracing.spec.ts:533 › should produce screencast frames fit `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145 › should watch all `@ubuntu-latest-node26`

52536 passed, 1270 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

8937 passed, 1489 skipped


Merge workflow run.

@dgozman
Dmitry Gozman (dgozman) merged commit a3c5084 into microsoft:main Oct 2, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

packages/extension fails typecheck on main (3 errors in connectedTabGroup.ts), and npm run tsc does not check it

2 participants