Fix TreeNodeFilter OR-pattern diagnostics by Evangelink · Pull Request #7415 · microsoft/testfx

Evangelink · 2026-02-14T21:41:12Z

Description

Partially addresses (does not fully fix) #7300. That issue reports four broken --treenode-filter patterns; this PR only improves the diagnostics and documentation for one of them and clarifies a known matching limitation that affects the other three.

Symptoms reported in #7300

#	Pattern	Observation
1	`///*/(MyTest1)`	Does not match a test named `MyTest1`
2	`///*/(MyTest1)\|(MyTest2)`	Does not match either test
3	`///*/(MyTest1\|MyTest2)`	Does not match either test
4	`(////MyTest1)\|(////MyTest2)`	Crashes with a generic `InvalidOperationException`

Analysis

Cases 1–3 are not a parser bug: (MyTest1) and (MyTest1\|MyTest2) do match a node whose final segment is exactly MyTest1 (see the new OrExpression_WorksForSinglePathSegmentInsideParentheses test). Path segments are matched against an anchored regex ^value$, so a literal MyTest1 will not match a node whose actual ID is MyTest1() (or anything else with extra suffix). TUnit appends method-signature info to the displayed name, so the node IDs the user is actually filtering against are most likely MyTest1(), MyTest2(), etc. — which is why every pattern with a wildcard like MyTest1* "works" while every literal one does not. This is a UX mismatch (display vs. node ID), not a TreeNodeFilter parser defect. Properly resolving it requires either action in TUnit's adapter (use stable IDs that match the displayed name) or a design change to relax literal-segment matching — both are out of scope here.
Case 4 is a real parser bug: full-path OR like (/A/B/C/X)\|(/A/B/C/Y) hits separator processing inside parentheses and throws a generic InvalidOperationException with no guidance. This PR replaces that with an actionable message that points the user to the supported form /A/B/C/(X|Y).

Changes

TreeNodeFilter.cs: thread the filter string into ProcessStackOperator so the "unexpected / inside parenthesized expression" error can include the filter and a suggested fix. Add grammar remarks noting that OR over a single path segment is supported but OR over full paths is not.
PlatformResources.resx (+ all xlf): new TreeNodeFilterUnexpectedSlashOperatorInPathSegmentErrorMessage resource (the previous one is preserved for back-compat; tests use the new message).
TreeNodeFilterTests.cs: regression tests for single-segment OR (OrExpression_WorksForSinglePathSegmentInsideParentheses), for the actionable error on full-path OR (FullPathOrInsideParenthesizedExpressions_IsNotSupported_ThrowsActionableMessage), and LiteralSegment_RequiresWildcardToMatchNodesWithAdditionalSuffix which documents (with a comment) the surprising literal-vs-suffix limitation behind cases 1–3.
Changelog-Platform.md: entry framed as a diagnostics/docs clarification, not a behavior fix.

Validation

dotnet test Microsoft.Testing.Platform.UnitTests.csproj -c Debug --filter "FullyQualifiedName~TreeNodeFilterTests" → 46/46 passing on net9.0/net8.0/net462.

Follow-ups (not in this PR)

The "literal segment does not match node ID with suffix" behavior (cases 1–3 of --treenode-filter pattern matching is at least non obvious, potentially errored #7300) remains as-is. Either TUnit should expose node IDs that match the displayed test name, or TreeNodeFilter should consider a relaxed/match-anywhere mode for literal segments. Leaving --treenode-filter pattern matching is at least non obvious, potentially errored #7300 open for that discussion.

Youssef1313

I have doubts that the problem here is clarity of error message. The behavior seems buggy IMO. Let's discuss offline.

…ode-filter

Evangelink · 2026-05-16T12:20:09Z

Merged latest main into the PR branch (was ~941 commits behind). The merge was clean with no conflicts. Verified the fix is still relevant — TreeNodeFilter.cs on main has not received an equivalent fix.

Verification:

Built Microsoft.Testing.Platform.csproj (Debug): 0 warnings, 0 errors.
Ran Microsoft.Testing.Platform.UnitTests filtered to TreeNodeFilter: 165 passed / 0 failed across net8.0, net9.0, net48.

Ready for CI re-run and review.

Copilot

Pull request overview

This PR clarifies TreeNodeFilter behavior for OR patterns and improves diagnostics when unsupported full-path OR expressions are parenthesized.

Changes:

Adds regression coverage for single-segment OR patterns and exact-match behavior.
Updates TreeNodeFilter grammar remarks and propagates filter text into parser error construction.
Improves the unexpected slash diagnostic for parenthesized full-path OR patterns.

Show a summary per file

File	Description
`test/UnitTests/Microsoft.Testing.Platform.UnitTests/Requests/TreeNodeFilterTests.cs`	Adds tests for supported OR syntax and unsupported parenthesized full-path OR diagnostics.
`src/Platform/Microsoft.Testing.Platform/Requests/TreeNodeFilter/TreeNodeFilter.cs`	Documents OR syntax limitations and augments the unexpected slash exception message.

Copilot's findings

Files reviewed: 2/2 changed files
Comments generated: 1

The merge of origin/main into this branch brought in many new resx entries (IsGreaterThan, IsLessThan, IsPositive, IsNegative, IsInRange, Contains*, DoesNotContain*, ContainsSingle, etc.). Regenerated all 13 XLF files via 'dotnet msbuild /t:UpdateXlf' to keep them in sync. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Move the inline hint diagnostic appended to TreeNodeFilterUnexpectedSlashOperatorErrorMessage into a new PlatformResources entry (TreeNodeFilterUnexpectedSlashOperatorInPathSegmentErrorMessage) so the full message is localized like the surrounding parser diagnostics. XLFs regenerated via UpdateXlf. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 29/29 changed files
Comments generated: 1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Evangelink · 2026-05-21T08:23:14Z

Reviewed the outstanding feedback and pushed bc8c8cf. Addressed the remaining actionable Copilot comment by adding the missing Changelog-Platform.md entry, then re-ran .\build.cmd successfully (0 warnings, 0 errors). I did not make further code changes for the older Youssef review because it reads as a discussion note ('Let's discuss offline') rather than concrete change guidance, and I skipped the already-handled localization thread because Evangelink had already replied there.

…ode-filter # Conflicts: # src/Platform/Microsoft.Testing.Platform/Requests/TreeNodeFilter/TreeNodeFilter.cs

Copilot

Copilot's findings

Files reviewed: 30/30 changed files
Comments generated: 1

Evangelink · 2026-05-23T15:28:44Z

🔍 Build Failure Analysis

Summary — Build failed due to out-of-sync localization files (.xlf) after modifying the FrameworkMessages.resx resource file.

Root cause: Localization files (.xlf) out of sync with .resx changes

The PR modifies src/TestFramework/TestFramework/Resources/FrameworkMessages.resx by adding multiple new resource keys and renaming existing ones (e.g., AreEqualDeltaFailMsg → AreEqualDeltaFailedSummary). While the corresponding .xlf localization files were updated in the PR, the Microsoft.DotNet.XliffTasks build validation detected that they are still out of sync with the source .resx file.

The XliffTasks validation enforces that all localization files must be perfectly synchronized with the source resource file to prevent translation drift in CI/official builds.

Affected files / errors

src/TestFramework/TestFramework/TestFramework.csproj:net8.0 — 'Resources/xlf/FrameworkMessages.cs.xlf' is out-of-date with 'Resources/FrameworkMessages.resx'
src/TestFramework/TestFramework/TestFramework.csproj:net9.0 — same error
src/TestFramework/TestFramework/TestFramework.csproj:netstandard2.0 — same error

Resource keys modified in FrameworkMessages.resx:

Renamed: AreEqualDeltaFailMsg → AreEqualDeltaFailedSummary
Renamed: AreNotEqualDeltaFailMsg → AreNotEqualDeltaFailedSummary
Renamed: HasCountFailMsg → HasCountFailedSummary
Renamed: IsNotEmptyFailMsg → IsNotEmptyFailedSummary
Added: AreNotSequenceEqualInAnyOrderFailedSummary, AreNotSequenceEqualInOrderFailedSummary, AreSequenceEqualInAnyOrderFailedSummary, AreSequenceEqualInOrderFailedSummary, and many more new resource keys

Proposed fix

Run the UpdateXlf MSBuild target to regenerate all .xlf files from the source .resx file:

dotnet build src/TestFramework/TestFramework/TestFramework.csproj /t:UpdateXlf

This will update all 13 localization files:

FrameworkMessages.cs.xlf (Czech)
FrameworkMessages.de.xlf (German)
FrameworkMessages.es.xlf (Spanish)
FrameworkMessages.fr.xlf (French)
FrameworkMessages.it.xlf (Italian)
FrameworkMessages.ja.xlf (Japanese)
FrameworkMessages.ko.xlf (Korean)
FrameworkMessages.pl.xlf (Polish)
FrameworkMessages.pt-BR.xlf (Portuguese-Brazil)
FrameworkMessages.ru.xlf (Russian)
FrameworkMessages.tr.xlf (Turkish)
FrameworkMessages.zh-Hans.xlf (Simplified Chinese)
FrameworkMessages.zh-Hant.xlf (Traditional Chinese)

After running the command, commit the updated .xlf files and push to this PR.

Build overview

Configuration: Debug
Exit code: 1 (failure)
Failed target: Build (XliffTasks validation)
Projects affected: TestFramework.csproj (all target frameworks: net8.0, net9.0, netstandard2.0)

All MSBuild errors (3)

Code	Project	File:Line	Message
(XliffTasks)	`TestFramework.csproj::net8.0`	`Microsoft.DotNet.XliffTasks.targets:84`	'Resources/xlf/FrameworkMessages.cs.xlf' is out-of-date with 'Resources/FrameworkMessages.resx'. Run `msbuild /t:UpdateXlf` to update .xlf files...
(XliffTasks)	`TestFramework.csproj::net9.0`	`Microsoft.DotNet.XliffTasks.targets:84`	'Resources/xlf/FrameworkMessages.cs.xlf' is out-of-date with 'Resources/FrameworkMessages.resx'. Run `msbuild /t:UpdateXlf` to update .xlf files...
(XliffTasks)	`TestFramework.csproj::netstandard2.0`	`Microsoft.DotNet.XliffTasks.targets:84`	'Resources/xlf/FrameworkMessages.cs.xlf' is out-of-date with 'Resources/FrameworkMessages.resx'. Run `msbuild /t:UpdateXlf` to update .xlf files...

_{🤖 Generated by the Build Failure Analysis workflow using binlog analysis · commit 948f3bd}

Generated by Build Failure Analysis for issue #7415 · ● 5.3M · ◷

Rename ExactMatch_DoesNotMatchAdditionalSuffixUnlessWildcardIsUsed to LiteralSegment_RequiresWildcardToMatchNodesWithAdditionalSuffix and add an explanatory comment so the test documents (not endorses) the surprising behavior reported in issue #7300 where node IDs include suffixes like '()' that literal filter segments don't match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The earlier 'Sync FrameworkMessages XLF files after merge with main' commit wiped existing translations and marked entries as state="new" because the resx values in this branch were unchanged from main. This PR does not touch FrameworkMessages.resx or AzureDevOpsResources.resx, so their xlf files must match main. Restore them from main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 25/25 changed files
Comments generated: 3

+    {
+        InvalidOperationException exception = Assert.ThrowsExactly<InvalidOperationException>(
+            () => _ = new TreeNodeFilter("(/*/*/*/MyTest1)|(/*/*/*/MyTest2)"));
+


      <trans-unit id="AzureDevOpsFlakyHistoryRequiresAzureDevOps">
        <source>'--report-azdo-flaky-history' requires '--report-azdo' to be enabled</source>
-        <target state="new">'--report-azdo-flaky-history' requires '--report-azdo' to be enabled</target>
+        <target state="translated">Aby bylo možné použít parametr ---report-azdo-flaky-history, musí být povolený parametr --report-azdo.</target>


      <trans-unit id="OptionDescription">
        <source>Enable Azure DevOps report generator to write errors to the output in a way that Azure DevOps understands.</source>
-        <target state="new">Enable Azure DevOps report generator to write errors to the output in a way that Azure DevOps understands.</target>
+        <target state="translated">Umožňuje generátoru sestav Azure DevOps zapisovat chyby do výstupu způsobem, který je pro AzureDev Ops srozumitelný.</target>


Fix TreeNodeFilter OR-pattern diagnostics

1a9c93e

Youssef1313 suggested changes Feb 16, 2026

View reviewed changes

microsoft-github-policy-service Bot assigned Evangelink Feb 16, 2026

microsoft-github-policy-service Bot added the needs/author-feedback Waiting on the original author. label Feb 16, 2026

microsoft-github-policy-service Bot added the state/stale No recent activity. label Feb 23, 2026

Youssef1313 removed needs/author-feedback Waiting on the original author. state/stale No recent activity. labels Feb 23, 2026

github-actions Bot mentioned this pull request Apr 8, 2026

[repo-status] Daily Repo Status — April 8, 2026 #7694

Closed

Merge remote-tracking branch 'origin/main' into dev/amauryleve/tree-n…

428a118

…ode-filter

Copilot AI review requested due to automatic review settings May 16, 2026 12:20

Copilot started reviewing on behalf of Evangelink May 16, 2026 12:21 View session

Copilot AI reviewed May 16, 2026

View reviewed changes

Comment thread src/Platform/Microsoft.Testing.Platform/Requests/TreeNodeFilter/TreeNodeFilter.cs Outdated

Copilot AI added 2 commits May 16, 2026 16:04

Copilot AI review requested due to automatic review settings May 16, 2026 15:07

Copilot started reviewing on behalf of Evangelink May 16, 2026 15:08 View session

Copilot AI reviewed May 16, 2026

View reviewed changes

Comment thread src/Platform/Microsoft.Testing.Platform/Requests/TreeNodeFilter/TreeNodeFilter.cs

Add changelog entry for TreeNodeFilter diagnostics

bc8c8cf

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into dev/amauryleve/tree-n…

948f3bd

…ode-filter # Conflicts: # src/Platform/Microsoft.Testing.Platform/Requests/TreeNodeFilter/TreeNodeFilter.cs

Copilot AI review requested due to automatic review settings May 23, 2026 15:18

Copilot started reviewing on behalf of Evangelink May 23, 2026 15:18 View session

Copilot AI reviewed May 23, 2026

View reviewed changes

Comment thread src/TestFramework/TestFramework/Resources/xlf/FrameworkMessages.cs.xlf Outdated

Evangelink and others added 2 commits May 25, 2026 13:37

Copilot AI review requested due to automatic review settings May 25, 2026 11:54

Copilot started reviewing on behalf of Evangelink May 25, 2026 11:54 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix TreeNodeFilter OR-pattern diagnostics#7415

Fix TreeNodeFilter OR-pattern diagnostics#7415
Evangelink wants to merge 8 commits into
mainfrom
dev/amauryleve/tree-node-filter

Evangelink commented Feb 14, 2026 •

edited

Loading

Uh oh!

Youssef1313 left a comment •

edited

Loading

Uh oh!

Evangelink commented May 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Evangelink commented May 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Evangelink commented May 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Evangelink commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Youssef1313 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Evangelink commented May 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Evangelink commented May 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Evangelink commented May 23, 2026

🔍 Build Failure Analysis

Root cause: Localization files (.xlf) out of sync with .resx changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Evangelink commented Feb 14, 2026 •

edited

Loading

Youssef1313 left a comment •

edited

Loading