Skip to content

[code-simplifier] Simplify logging helper methods in JsonConfigurationProvider #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
May 27, 2026
+6 −21
Merged

[code-simplifier] Simplify logging helper methods in JsonConfigurationProvider #8603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 6 additions & 21 deletions src/Platform/Microsoft.Testing.Platform/Configurations/JsonConfigurationProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,29 +26,14 @@ internal sealed class JsonConfigurationProvider(

public string? ConfigurationFile { get; private set; }

private async Task LogInformationAsync(string message)
{
if (_logger is not null)
{
await _logger.LogInformationAsync(message).ConfigureAwait(false);
}
}
private Task LogInformationAsync(string message)
=> _logger?.LogInformationAsync(message) ?? Task.CompletedTask;

private async Task LogDebugAsync(string message)
{
if (_logger is not null)
{
await _logger.LogDebugAsync(message).ConfigureAwait(false);
}
}
private Task LogDebugAsync(string message)
=> _logger?.LogDebugAsync(message) ?? Task.CompletedTask;

private async Task LogErrorAsync(string message, Exception exception)
{
if (_logger is not null)
{
await _logger.LogErrorAsync(message, exception).ConfigureAwait(false);
}
}
private Task LogErrorAsync(string message, Exception exception)
=> _logger?.LogErrorAsync(message, exception) ?? Task.CompletedTask;

public async Task LoadAsync()
{
Expand Down