fix: double backslash when escaping string syntax #9275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Biret <[email protected]>
baywet
requested review from
AlitzelMendez,
chrisradek,
markcowl,
timotheeguerin and
witemple-msft
as code owners
microsoft-github-policy-service
bot
added
the
emitter:openapi3
Signed-off-by: Vincent Biret <[email protected]>
Contributor
|
All changed packages have been documented.
|
commit: |
Collaborator
|
You can try these changes here
|
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
markcowl
reviewed
Dec 30, 2025
Contributor
markcowl
left a comment
markcowl
left a comment
There was a problem hiding this comment.
The actual logic looks fine, although I wonder . I think we should scrub the actual data for mentions of companies, persons, and the like
packages/openapi3/test/tsp-openapi3/convert-openapi3-doc.test.ts
Outdated
Show resolved
Hide resolved
baywet
commented
Dec 30, 2025
packages/openapi3/test/tsp-openapi3/convert-openapi3-doc.test.ts
Outdated
Show resolved
Hide resolved
markcowl
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9236 and #9228 introduced regressions where some syntax could end up being escaped twice, causing compilation issues after import
This is an attempt to definitively fix all the escaping issues, not letting copilot drive...