agent host: adopt durable error response parts - #332606
Merged
Merged
Conversation
Sync the generated AHP types to b4016c0e and adapt existing error producers, restored sessions, UI consumers, telemetry, and tests to the durable response-part shape. This intentionally does not expose turn resume behavior.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: TylerLeonhardtMatched files:
|
Remove the obsolete Turn.error expectation after adopting durable error response parts.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adopts durable Agent Host error response parts across protocol state, providers, restoration, telemetry, rendering, and tests.
Changes:
- Syncs generated protocol definitions to
b4016c0e. - Migrates error producers and consumers to
ErrorResponsePart. - Includes turn-resume protocol types without UI support.
Review finding: Backward compatibility for legacy error payloads is incomplete, and unsupported resume actions are not rejected.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/test/browser/agentSessions/stateToProgressAdapter.test.ts |
Updates restored-error tests. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/importLocalConversationToAgentSession.test.ts |
Updates imported-error assertions. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatContribution.test.ts |
Normalizes legacy test errors. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/stateToProgressAdapter.ts |
Reads durable turn errors. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/importLocalConversationToAgentSession.ts |
Stores imported errors as parts. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSessionHandler.ts |
Uses durable errors and narrows tool requests. |
src/vs/platform/agentHost/test/node/protocol/turnExecution.integrationTest.ts |
Updates protocol error assertion. |
src/vs/platform/agentHost/test/node/mockAgent.ts |
Emits durable error actions. |
src/vs/platform/agentHost/test/node/mapSessionEvents.test.ts |
Verifies restored error parts. |
src/vs/platform/agentHost/test/node/e2e/suites/multiChatSuite.ts |
Updates E2E error handling. |
src/vs/platform/agentHost/test/node/e2e/suites/coreSuite.ts |
Updates typed error assertions. |
src/vs/platform/agentHost/test/node/e2e/suites/copilotCoverageSuite.ts |
Reads durable errors. |
src/vs/platform/agentHost/test/node/e2e/providers/copilotAgentHostE2E.integrationTest.ts |
Verifies durable restored errors. |
src/vs/platform/agentHost/test/node/e2e/harness/ahpSnapshot.ts |
Projects durable error actions. |
src/vs/platform/agentHost/test/node/e2e/harness/agentHostE2ETestHarness.ts |
Updates harness error reporting. |
src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts |
Verifies emitted error parts. |
src/vs/platform/agentHost/test/node/codex/codexReplayMapper.test.ts |
Verifies replayed durable errors. |
src/vs/platform/agentHost/test/node/codex/codexMapAppServerEvents.test.ts |
Updates Codex action expectation. |
src/vs/platform/agentHost/test/node/claudeMapSessionEvents.test.ts |
Reads Claude error parts. |
src/vs/platform/agentHost/test/node/chatContributions.test.ts |
Updates contribution error actions. |
src/vs/platform/agentHost/test/node/agentSideEffects.test.ts |
Migrates side-effect fixtures. |
src/vs/platform/agentHost/test/node/agentHostTurnTelemetry.test.ts |
Migrates telemetry fixtures. |
src/vs/platform/agentHost/test/node/agentHostStateManager.test.ts |
Updates reducer fixture. |
src/vs/platform/agentHost/node/copilot/mapSessionEvents.ts |
Restores errors as response parts. |
src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts |
Emits durable Copilot errors. |
src/vs/platform/agentHost/node/codex/codexReplayMapper.ts |
Restores durable Codex errors. |
src/vs/platform/agentHost/node/codex/codexMapAppServerEvents.ts |
Maps Codex failures to parts. |
src/vs/platform/agentHost/node/codex/codexAgent.ts |
Migrates Codex error producers. |
src/vs/platform/agentHost/node/claude/claudeMapSessionEvents.ts |
Migrates Claude error producer. |
src/vs/platform/agentHost/node/chatContributions/queueDrain/queueDrainContribution.ts |
Migrates queue failure action. |
src/vs/platform/agentHost/node/agentSideEffects.ts |
Consumes and emits error parts. |
src/vs/platform/agentHost/common/state/sessionState.ts |
Adds durable-error accessor. |
src/vs/platform/agentHost/common/state/protocol/version/registry.ts |
Registers resume action version. |
src/vs/platform/agentHost/common/state/protocol/common/notifications.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/common/errors.ts |
Syncs protocol error contract. |
src/vs/platform/agentHost/common/state/protocol/common/commands.ts |
Syncs command documentation. |
src/vs/platform/agentHost/common/state/protocol/common/actions.ts |
Adds resume action type. |
src/vs/platform/agentHost/common/state/protocol/channels-terminal/state.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/channels-session/state.ts |
Narrows tool execution state. |
src/vs/platform/agentHost/common/state/protocol/channels-session/commands.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/channels-root/state.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/channels-resource-watch/state.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/channels-resource-watch/commands.ts |
Corrects documentation link. |
src/vs/platform/agentHost/common/state/protocol/channels-chat/state.ts |
Defines durable error parts. |
src/vs/platform/agentHost/common/state/protocol/channels-chat/reducer.ts |
Stores errors and supports resume. |
src/vs/platform/agentHost/common/state/protocol/channels-chat/commands.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/channels-chat/actions.ts |
Changes error action and adds resume. |
src/vs/platform/agentHost/common/state/protocol/channels-changeset/state.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/channels-changeset/commands.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/channels-automation/state.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/channels-automation-run/state.ts |
Syncs enum metadata. |
src/vs/platform/agentHost/common/state/protocol/action-origin.generated.ts |
Marks resume client-dispatchable. |
src/vs/platform/agentHost/common/state/protocol/.ahp-version |
Records synced protocol commit. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 54/54 changed files
- Comments generated: 3
- Review effort level: Balanced
Normalize legacy live and restored error shapes before reduction, and reject turn resume until provider support exists. This preserves behavior with negotiated older hosts while keeping resume disabled.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
enabled auto-merge (squash)
August 25, 2026 21:03
Anthony Kim (anthonykim1)
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b4016c0e)The generated protocol includes the upstream turn-resume action and reducer support, but this change intentionally adds no resume UI, command, or new user-facing behavior.
Validation
npm run compilenpm run hygienenpm run typecheck-clientnpm run transpile-client(Written by Copilot)