Skip to content

fix(desktop): compact sidebar footer shortcuts - #305

Merged
Angnuo (angnuoli) merged 1 commit into
mainfrom
codex/sidebar-footer-icons
Nov 2, 2026
Merged

Angnuo (angnuoli) merged 1 commit into
mainfrom
codex/sidebar-footer-icons

Conversation

@angnuoli

Copy link
Copy Markdown
Collaborator

Description

Replace the sidebar's labeled WeChat/settings entries with a compact, consistent icon-only footer.

Related Issue

None.

Changes

  • Move Settings into the bottom-left footer alongside the phone/device shortcut.
  • Replace the green WeChat image and label with a monochrome device icon; keep the existing connection popover.
  • Use 16px icons with 36px click targets, hover titles, accessible labels, keyboard focus, and current-page state.
  • Cover English/Chinese labels, icon dimensions, footer placement, and settings navigation with component tests.

Type of Change

  • Bug fix (non-breaking UI refinement)

Testing

  • Targeted renderer tests: npm test --prefix desktop/renderer -- src/components/SidePanel.test.ts src/components/WeixinConnectionShortcut.test.ts (24 tests passed)
  • Renderer build: cd desktop/renderer && npm run build
  • Prettier check for all four changed files
  • git diff --check
  • Manual browser preview of footer layout, settings navigation, and the connection popover

Checklist

  • Self-review completed; changes are limited to the requested UI and related tests.
  • Existing connection behavior is preserved.
  • No new dependencies or configuration changes.

Merge Instructions

The requester explicitly asked for an immediate manual squash merge without waiting for CI.

@angnuoli
Angnuo (angnuoli) merged commit acb61d8 into main Nov 2, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant