Skip to content

Support query iterator cursor - #2045

Merged
sre-ci-robot merged 2 commits into
milvus-io:masterfrom
yhmo:mm
Aug 26, 2026
Merged

Support query iterator cursor#2045
sre-ci-robot merged 2 commits into
milvus-io:masterfrom
yhmo:mm

Conversation

@yhmo

@yhmo yhmo commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 25, 2026 10:22

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@mergify mergify Bot added the ci-passed label Aug 25, 2026
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.53846% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@9f16ab0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...va/io/milvus/orm/iterator/QueryIteratorCursor.java 80.00% 4 Missing and 4 partials ⚠️
...ain/java/io/milvus/orm/iterator/QueryIterator.java 89.47% 1 Missing and 1 partial ⚠️
...us/v2/service/vector/request/QueryIteratorReq.java 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2045   +/-   ##
=========================================
  Coverage          ?   67.37%           
  Complexity        ?     4973           
=========================================
  Files             ?      485           
  Lines             ?    29223           
  Branches          ?     2916           
=========================================
  Hits              ?    19689           
  Misses            ?     8004           
  Partials          ?     1530           
Files with missing lines Coverage Δ
...ain/java/io/milvus/orm/iterator/QueryIterator.java 96.61% <89.47%> (ø)
...us/v2/service/vector/request/QueryIteratorReq.java 74.75% <66.66%> (ø)
...va/io/milvus/orm/iterator/QueryIteratorCursor.java 80.00% <80.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread sdk-core/src/main/java/io/milvus/orm/iterator/QueryIterator.java
Signed-off-by: yhmo <yihua.mo@zilliz.com>
Comment thread examples/src/main/java/io/milvus/v2/IteratorExample.java Outdated
Comment thread sdk-core/src/main/java/io/milvus/orm/iterator/QueryIterator.java
@mergify mergify Bot added ci-passed and removed ci-passed labels Aug 26, 2026
- resume the example with limit - firstPage.size() so the combined total
  stays at limit (the limit is per-iterator)
- add queryIteratorResumesVarcharPkFromCursor to cover the quoted
  varchar pk > "..." resume expression

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@mergify mergify Bot added the ci-passed label Aug 26, 2026
@yhmo yhmo added the lgtm label Aug 26, 2026
@sre-ci-robot
sre-ci-robot merged commit 81e7e87 into milvus-io:master Aug 26, 2026
8 checks passed
sre-ci-robot pushed a commit that referenced this pull request Aug 26, 2026
* Support query iterator cursor



* Address review comments on query iterator cursor

- resume the example with limit - firstPage.size() so the combined total
  stays at limit (the limit is per-iterator)
- add queryIteratorResumesVarcharPkFromCursor to cover the quoted
  varchar pk > "..." resume expression



---------


(cherry picked from commit 81e7e87)

Signed-off-by: yhmo <yhmo@users.noreply.github.com>
@yhmo
yhmo deleted the mm branch August 26, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants