Refactor of Unit tests to reduce reliance on Dummy Classes #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… provider test files - Updated test method names to follow camelCase convention in DiscordProviderTest, LaravelPassportProviderTest, SteamProviderTest, TwitchProviderTest, AbstractTicketProviderTest, FakeProviderTest, GenericTicketProviderTest, InternalTicketProviderTest, TicketTailorProviderTest, WooCommerceProviderTest, and other ticket provider tests. - Ensured all test methods are descriptive and adhere to a consistent naming pattern for better readability and maintainability. Signed-off-by: David Eberhardt <[email protected]>
Signed-off-by: David Eberhardt <[email protected]>
…g PBPCBF on Tests) Signed-off-by: David Eberhardt <[email protected]>
… remove dummy classes Signed-off-by: David Eberhardt <[email protected]>
…ormers with inline classes and simplify setup Signed-off-by: David Eberhardt <[email protected]>
… inline class and simplify provider instance creation Signed-off-by: David Eberhardt <[email protected]>
…ith inline classes and simplify provider creation Signed-off-by: David Eberhardt <[email protected]>
…plify provider creation Signed-off-by: David Eberhardt <[email protected]>
…etup Signed-off-by: David Eberhardt <[email protected]>
…vider helper and simplify provider creation Signed-off-by: David Eberhardt <[email protected]>
…vider helper and simplify provider creation Signed-off-by: David Eberhardt <[email protected]>
…orProvider helper and simplify test setup Signed-off-by: David Eberhardt <[email protected]>
…Provider helper and simplify test setup Signed-off-by: David Eberhardt <[email protected]>
… for improved encapsulation Signed-off-by: David Eberhardt <[email protected]>
… readability and maintainability Signed-off-by: David Eberhardt <[email protected]>
…etProvider, and DummyWooCommerceProvider in favor of factory-based test doubles and ReflectionHelpers Signed-off-by: David Eberhardt <[email protected]>
Signed-off-by: David Eberhardt <[email protected]>
…nd update HTTP header naming conventions for webhook requests Signed-off-by: David Eberhardt <[email protected]>
…stent API endpoint usage Signed-off-by: David Eberhardt <[email protected]>
…verage Signed-off-by: David Eberhardt <[email protected]>
…emove unused dummy provider classes Signed-off-by: David Eberhardt <[email protected]>
…ControllerTest to use factories for provider settings Signed-off-by: David Eberhardt <[email protected]>
… consistency and clarity in TicketProviderContractTest Signed-off-by: David Eberhardt <[email protected]>
…cketProviderContractTest for improved clarity Signed-off-by: David Eberhardt <[email protected]>
…ialProviderInstallTest and AbstractTransformerExtraTest for improved clarity; add config mapping validation test in GenericTicketProviderTest Signed-off-by: David Eberhardt <[email protected]>
…ansformerExtraTest; remove unused NoopTransformer and PrecedenceTransformer classes Signed-off-by: David Eberhardt <[email protected]>
…ce with anonymous subclasses for improved clarity and maintainability Signed-off-by: David Eberhardt <[email protected]>
…tory method for improved clarity and maintainability in AbstractSocialProviderResolveTest Signed-off-by: David Eberhardt <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #65 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1155 1155
===========================================
Files 136 136
Lines 4053 4053
===========================================
Hits 4053 4053 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
….php; instantiate GenericTicketProvider directly in config mapping tests for improved clarity Signed-off-by: David Eberhardt <[email protected]>
…e readability by adding space in class instantiation Signed-off-by: David Eberhardt <[email protected]>
Contributor
Author
|
Missed my last commit which should have plugged that last gap again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snake_caseName to PHP standards