Added extra check in getContentLength method. #166
Open
kamlesh1988 wants to merge 1 commit intomitre:masterfrom
Open
Added extra check in getContentLength method. #166kamlesh1988 wants to merge 1 commit intomitre:masterfrom
kamlesh1988 wants to merge 1 commit intomitre:masterfrom
Conversation
…engthHeader) was throwing exception in case content-length header is present but its blank string
Collaborator
|
is a blank header even valid? Is a header with spaces even valid? FYI see String.isBlank which is better than trimming to only check if non-empty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long.parseLong(contentLengthHeader) was throwing an exception in case content-length header is present but its blank string
