fix: resolve citations when model prepends a toolu_ prefix#888
Merged
Conversation
Some models cite search results as [n](#toolu_<id>) even though the search tool's call id has no prefix, which broke the exact-match lookup in processCitations and silently dropped the citation. - citation.ts: fall back to prefix-normalized matching (toolu_/call_/ search-) after trying an exact match first - search-mode-prompts.ts: drop the toolu_ prefix from citation examples and tell the model not to add any prefix to the toolCallId - add tests covering prefixed and exact-match resolution
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some models cite search results as
[n](#toolu_<id>)even though the search tool's call id has no prefix. The exact-match lookup inprocessCitationsmissed these and silently dropped the citation on render.Changes
lib/utils/citation.ts: try an exacttoolCallIdmatch first, then fall back to prefix-normalized matching (toolu_/call_/search-) on both the cited id and the citation map keys. This also retroactively fixes already-persisted messages.lib/agents/prompts/search-mode-prompts.ts: drop thetoolu_prefix from citation examples and instruct the model not to add any prefix to thetoolCallId.lib/utils/__tests__/citation.test.ts: add coverage for prefixed-id resolution and confirm exact matches still take precedence.Verification
bun run test✅bun lint✅bun typecheck✅bun format:check(changed files) ✅bun run build✅