Added: PSR2, protected for options and conditional for Logger#1
Open
dariuszwrzesien wants to merge 3 commits intomlabrum:masterfrom
dariuszwrzesien:master
Open
Added: PSR2, protected for options and conditional for Logger#1dariuszwrzesien wants to merge 3 commits intomlabrum:masterfrom dariuszwrzesien:master
dariuszwrzesien wants to merge 3 commits intomlabrum:masterfrom
dariuszwrzesien:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. Thanks for your package.
If you don't mind I suggest a few improvements there. It seems like a lot of changes here but it really doesn't. It looks like that because I've added PSR-2 formating. I've changed $options from private to protected because I extend your classes in my code. I've added conditional to check if $this->logger is not null (in __doRequest) - I don't use that logger in my code.
Thanks again and I hope you will like the improvements.