universal memory system - #12
Open
mnemonik-dev wants to merge 42 commits into
Open
Conversation
Phase 1 scope: circom+snarkjs circuit for 3-clause payment policy, policy-certs npm package, optional middleware hook. Based on arxiv:2606.23768. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… local/cloud isolation warning Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ntent limits, DEV-1 resolution Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… suggestion Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ransport, adapter 90% done, task 4 repurposed) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 rounds × 3 reviewers. All findings resolved by round 2: - CR-1/CR-5: removed duplicate SynthesisResult from local.ts - CR-3: simplified pglite.ts return type to BrainEngine - TEST-1/TEST-2: added mode detection tests to config.test.ts - TEST-3: removed dead mock declaration Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Key deviations: createEngine() uses database_path (not dataDir), ParsedCitation maps page_slug→id + slug#row→excerpt, Anthropic branch omits embedding_model (Anthropic has none). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documents: WebStandardStreamableHTTPServerTransport choice (Bun-native vs Node.js wrapper), zero-padding timingSafeEqual trick, stateless mode rationale, CloudAdapter deferred-throw pattern, smoke verification results, and spec deviation (serve-http.ts → http-transport.ts). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Round 1 findings: CR-4 (htmlToText raw HTML), CR-5 (PDF error fallback), SA-2 (IPv6 private ranges), SA-1 (DNS rebinding doc), SA-3 (double check doc), TR-2 (PDF test), TR-1 (redirect comment), IPv6 SSRF tests. Round 2: all required findings resolved, all three reviewers approved. 86 tests passing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documents ingestion pipeline architecture, SSRF IPv6 coverage, PDF API behavior in Bun ESM, and MEMORY_ALLOWED_DIRS default value. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code-reviewer and test-reviewer both approved (round 2). CR-4 (defensive created_at) and TR-5 (stronger assertion) applied. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documents rename, list/delete wiring, IngestPipeline.add alias, StorageAdapter extension, test approach, and review findings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Round 1 reports from code-reviewer and test-reviewer for Task 5 (CloudAdapter real implementation + verify synthesize). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 JSON review files in logs/working/task-6/: - code-reviewer-round1.json: 4 findings (CR-1 major hash bug, CR-2 minor empty guard, CR-3/4 low) - security-auditor-round1.json: 4 findings (SA-1/3 minor JWT leakage, SA-2/4 low) - test-reviewer-round1.json: 4 findings (TR-1 major hash param, TR-2/3/4 minor) - All round-2 reports: approve (all actionable findings fixed) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documents: createMnemonikAdapter() factory pattern, tools/sign.ts idempotency logic (SHA-256 dedup key, CR-1 fix), tools/verify.ts delegation pattern, memory_attestations migration, redactJWT() error redaction (D13), and all review findings applied in round 1. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Round 1 findings from code-reviewer, security-auditor, deploy-reviewer. All required fixes applied in preceding commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
code-reviewer round 1: 5 findings (CR9-1 through CR9-5), approved_with_minor_findings test-reviewer round 1: 5 findings (TR9-1 through TR9-5), approved_with_minor_findings Applied: CR9-1 (select import), CR9-2 (docstring), TR9-5 (edge case tests) Accepted: CR9-3, CR9-5, TR9-1, TR9-2, TR9-3, TR9-4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.