Skip to content

Add Apache 2.0 licensing and enforce SPDX headers - #3

Merged
thaJeztah merged 3 commits into
moby:masterfrom
vvoland:add-license
Sep 18, 2026
Merged

Add Apache 2.0 licensing and enforce SPDX headers#3
thaJeztah merged 3 commits into
moby:masterfrom
vvoland:add-license

Conversation

@vvoland

@vvoland vvoland commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

@vvoland
vvoland requested a review from thaJeztah September 16, 2026 18:42
@vvoland vvoland mentioned this pull request Sep 16, 2026
Closed
thaJeztah
thaJeztah requested changes Sep 17, 2026
View reviewed changes

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! left a comment 😅

Comment thread client/client.go
Comment thread hack/lint-license.sh
@vvoland
Add Apache 2.0 licensing and enforce SPDX headers
e5d80bc 
Signed-off-by: Paweł Gronowski <git@grono.dev>
@vvoland
cmd/mobyextgen: Preserve contract copyright and license notices
587697f 
Signed-off-by: Paweł Gronowski <git@grono.dev>
@thaJeztah

thaJeztah commented Sep 17, 2026

Copy link
Copy Markdown
Member

Failure looks legit;

GO="go" bash hack/lint-generate.sh
fatal: detected dubious ownership in repository at '/workspace'
To add an exception for this directory, call:

	git config --global --add safe.directory /workspace
make: *** [Makefile:53: lint-generate] Error 128
make: *** [Makefile:21: lint] Error 2
Error: Process completed with exit code 2.

@vvoland
Makefile: Check generated files during lint
3b3ce52 
Signed-off-by: Paweł Gronowski <git@grono.dev>
@vvoland

vvoland commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed

@vvoland
vvoland requested a review from thaJeztah September 18, 2026 00:02
thaJeztah
thaJeztah approved these changes Sep 18, 2026
View reviewed changes

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@thaJeztah
thaJeztah merged commit 8e08b0b into moby:master Sep 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add a License

2 participants

@vvoland @thaJeztah