archive: test chmod fallback without procfs in chroot - #105
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 65.81% 64.17% -1.65%
==========================================
Files 42 44 +2
Lines 2039 3045 +1006
==========================================
+ Hits 1342 1954 +612
- Misses 519 877 +358
- Partials 178 214 +36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thaJeztah
force-pushed
the
test_chrooted_chmod_fallback
branch
from
August 4, 2026 17:02
9e0e59a to
8e3c767
Compare
1 task
Add a regression test that runs the chmod fallback after switching into a temporary root without procfs mounted. This reproduces the environment used by chrootarchive, where resolving an O_PATH descriptor through /proc/self/fd is unavailable. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
test_chrooted_chmod_fallback
branch
from
August 4, 2026 17:20
8e3c767 to
3daca2a
Compare
thaJeztah
marked this pull request as ready for review
August 4, 2026 17:23
Member
Author
|
verified in the other PR; currently failing with that fix; |
vvoland
approved these changes
Aug 4, 2026
| } | ||
| defer unix.Close(parentFD) | ||
|
|
||
| if err := chmodNoSymlinkFallback(parentFD, filepath.Base(name), name, 0o644); err != nil { |
Contributor
There was a problem hiding this comment.
For a follow up, we should consider reshaping the test suite so we run more cases in this setup
Member
Author
There was a problem hiding this comment.
Yeah, I think we should look at moving some of these components to an internal/ package, so that we can more easily re-use or differentiate the underlying components, instead of making chrootarchive just wrap the whole thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression test that runs the chmod fallback after switching into a temporary root without procfs mounted.
This reproduces the environment used by chrootarchive, where resolving an O_PATH descriptor through /proc/self/fd is unavailable.