Skip to content

avoid retaining tar headers for unpacked dirs - #110

Merged
thaJeztah merged 1 commit into
moby:mainfrom
crazy-max:reduce-unpacked-dir-retention
Aug 13, 2026
Merged

avoid retaining tar headers for unpacked dirs#110
thaJeztah merged 1 commit into
moby:mainfrom
crazy-max:reduce-unpacked-dir-retention

Conversation

@crazy-max

Copy link
Copy Markdown
Member

Store only the root-relative directory name and bounded access/modification times while deferring directory timestamp restoration.

The full tar header is still consumed immediately when creating each entry, so the delayed pass no longer keeps per-directory header metadata alive until extraction completes.

Store only the root-relative directory name and bounded access/modification times
while deferring directory timestamp restoration.

The full tar header is still consumed immediately when creating each entry, so the
delayed pass no longer keeps per-directory header metadata alive until extraction
completes.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.14%. Comparing base (e738eed) to head (2c0cbf1).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
archive.go 83.33% 0 Missing and 1 partial ⚠️
diff.go 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   65.25%   65.14%   -0.11%     
==========================================
  Files          46       46              
  Lines        2377     2384       +7     
==========================================
+ Hits         1551     1553       +2     
- Misses        606      609       +3     
- Partials      220      222       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@crazy-max
crazy-max requested review from thaJeztah and vvoland August 13, 2026 07:48
@crazy-max
crazy-max marked this pull request as ready for review August 13, 2026 07:48

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@thaJeztah
thaJeztah merged commit a26ea67 into moby:main Aug 13, 2026
12 checks passed
@crazy-max
crazy-max deleted the reduce-unpacked-dir-retention branch August 13, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants