cache implied directory parent during unpack - #112
Closed
crazy-max wants to merge 1 commit into
Closed
Conversation
Avoid repeated parent directory checks for consecutive archive entries that share the same implicit parent. Clear the cache after extraction-side removals so whiteouts and replacements cannot reuse stale parent state. Add a whiteout regression test and benchmarks for the implied-directory path. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 65.25% 65.35% +0.10%
==========================================
Files 46 46
Lines 2377 2390 +13
==========================================
+ Hits 1551 1562 +11
Misses 606 606
- Partials 220 222 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
While reviewing I thought about a bit simpler solution without having to maintain the mutable cache.. See #113. Let me know if it looks better to you as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid repeated parent directory checks for consecutive archive entries that share the same implicit parent.
Clear the cache after extraction-side removals so whiteouts and replacements cannot reuse stale parent state. Add a whiteout regression test and benchmarks for the implied-directory path.