avoid per-entry xattr path wrapper during unpack - #114
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 65.25% 65.64% +0.39%
==========================================
Files 46 46
Lines 2377 2393 +16
==========================================
+ Hits 1551 1571 +20
+ Misses 606 602 -4
Partials 220 220 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
crazy-max
marked this pull request as ready for review
August 14, 2026 14:27
createTarFile used sync.OnceValues to delay resolving the bounded filesystem path until an xattr PAX record was found, but that still created the lazy wrapper for every extracted entry. Track the resolved path with simple local state inside the xattr loop instead, so entries without SCHILY.xattr records avoid that setup while entries with xattrs still resolve the path only once. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
lazy-xattr-path-resolution
branch
from
August 14, 2026 14:38
fadc76f to
66cf06f
Compare
crazy-max
changed the title
vvoland
approved these changes
Aug 14, 2026
Member
|
Ah, yeah, I probably should've removed it in 51d1dd0 - before that there were multiple paths calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createTarFile used sync.OnceValues to delay resolving the bounded filesystem path until an xattr PAX record was found, but that still created the lazy wrapper for every extracted entry.
Track the resolved path with simple local state inside the xattr loop instead, so entries without SCHILY.xattr records avoid that setup while entries with xattrs still resolve the path only once.