Tweak principia_make.sh cmake flags - #4
Open
ts826848 wants to merge 21 commits into
Open
Conversation
…Ultimately this should really use gtest.
…h step of 1 makes perfect sense, on the other hand a negative step would cause trouble.
principia_make
CMAKE_LD_FLAGS isn't recognized by CMake:
CMake Warning:
Manually-specified variables were not used by the project:
CMAKE_LD_FLAGS
No replacement is needed since static libraries are created for
consumption by Principia and those use ar instead of ld.
"." is added to the command line to future-proof the command against
future CMake releases:
CMake Warning:
No source or binary directory provided. Both will be assumed to be the
same as the current working directory, but note that this warning will
become a fatal error in future CMake releases.
pleroy
force-pushed
the
master
branch
3 times, most recently
from
April 4, 2026 22:02
9600415 to
cd81e00
Compare
pleroy
added a commit
that referenced
this pull request
Apr 4, 2026
# This is the 1st commit message: # This is a combination of 3 commits. # This is the 1st commit message: The files that we ignore. # This is the commit message #2: Bring back our MSVC files and incorporate new source files. # This is the commit message #3: A script to generate project files. # This is the commit message #2: MSVC setup: ignore file, solution, props, projects and a script to generate them. # This is the commit message #3: Regenerate the project files using build_projects_helper.ps1. # Conflicts: # msvc/google-benchmark-test.vcxproj # This is the commit message #4: Split the tests into 3 projects. # This is the commit message #5: Add dependencies on gtest/gmock. # This is the commit message #6: Handle special files when generating the "other" project. # This is the commit message #7: Only one project depends on gtest.
pleroy
added a commit
that referenced
this pull request
Apr 4, 2026
# This is the 1st commit message: # This is a combination of 3 commits. # This is the 1st commit message: The files that we ignore. # This is the commit message #2: Bring back our MSVC files and incorporate new source files. # This is the commit message #3: A script to generate project files. # This is the commit message #2: MSVC setup: ignore file, solution, props, projects and a script to generate them. # This is the commit message #3: Regenerate the project files using build_projects_helper.ps1. # Conflicts: # msvc/google-benchmark-test.vcxproj # This is the commit message #4: Split the tests into 3 projects. # This is the commit message #5: Add dependencies on gtest/gmock. # This is the commit message #6: Handle special files when generating the "other" project. # This is the commit message #7: Only one project depends on gtest. # This is the commit message google#8: Restructure the projects (again).
pleroy
force-pushed
the
master
branch
2 times, most recently
from
April 4, 2026 22:08
5d65239 to
79510fd
Compare
pleroy
force-pushed
the
master
branch
4 times, most recently
from
April 9, 2026 18:23
658f3ef to
c79e75a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_LD_FLAGSisn't recognized by CMake:No replacement is needed since static libraries are created for
consumption by Principia and those use
arinstead ofld."." is added to the command line to future-proof the command against
future CMake releases: