add error handling for onprogress disconnects (stop server crashing) #1282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to the _onProgress handler to follow the exception pattern used elsewhere in the SDK. At the moment, exceptions in the handler terminate the Node process with:
Specific scenario is usage in a proxy scenario, where Progress Notifications are relayed from the Server to the Client, and the Client disconnects with a close handler.
To demonstrate the failure:
tsx src/examples/client/disconnectTestServer.tstsx src/examples/client/disconnectTestClient.tsThe Client terminates after 5 notifications, triggering the error condition.
Server output after fix:
Notes on the test programs: