feat(benchmarks): add ACEBench support, fix #1025#1386
Open
haoruilee wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for the ACEBench tool-use benchmark, adding documentation, metadata, an adapter, utility functions, and corresponding unit tests. The review feedback focuses on improving the robustness of the adapter and utility implementations by recommending defensive checks against null or missing values, handling potential parsing exceptions (such as invalid JSON or AST parsing errors), ensuring type safety for unexpected inputs, and standardizing boolean string coercion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ACEBench support to EvalScope.
evalscope/benchmarks/acebench/acebench_adapter.py, inheriting fromDefaultDataAdapter.acebenchbenchmark withnormal,special, andagentsubsets.Has ran a real test on my own API to test.