fix: normalize newlines in variable comparison for resource sync#1172
Open
litlmike wants to merge 1 commit intomoghtech:mainfrom
Open
fix: normalize newlines in variable comparison for resource sync#1172litlmike wants to merge 1 commit intomoghtech:mainfrom
litlmike wants to merge 1 commit intomoghtech:mainfrom
Conversation
When a TOML variable contains newlines (multi-line literal strings), the TOML parser normalizes line endings to \n, but values stored in the database may contain \r\n. This mismatch causes the resource sync status checker to perpetually show a pending update state, even though the diff shows identical content on both sides. Fix by normalizing \r\n to \n before comparing variable values and descriptions. Fixes moghtech#627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a TOML variable contains newlines (multi-line literal string like
"""..."""), the resource sync status checker shows a perpetual "pending update" state. The diff comparison shows identical content on both sides with no change markers.This happens because the TOML parser normalizes line endings to
\n, but values stored in the database (e.g. via the web UI) may contain\r\n. The direct string equality check sees them as different even though the content is semantically identical.Fix
Normalize
\r\nto\nbefore comparing variable values and descriptions in bothget_updates_for_viewandget_updates_for_execution.Fixes #627