-
Notifications
You must be signed in to change notification settings - Fork 31
CLOUDP-364847: Remove unused MDB_IMAGE_TYPE environment variable #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Julien-Ben
wants to merge
5
commits into
master
Choose a base branch
from
jben/CLOUDP-361051_remove-unused-image-type-env
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CLOUDP-364847: Remove unused MDB_IMAGE_TYPE environment variable #641
Julien-Ben
wants to merge
5
commits into
master
from
jben/CLOUDP-361051_remove-unused-image-type-env
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.1 Release NotesBug Fixes
Other Changes
|
Julien-Ben
commented
Dec 10, 2025
| value: mongodb-enterprise-server | ||
| - name: MONGODB_REPO_URL | ||
| value: quay.io/mongodb | ||
| - name: MDB_IMAGE_TYPE |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reference architecture file
m1kola
approved these changes
Dec 10, 2025
anandsyncs
approved these changes
Dec 10, 2025
Collaborator
Author
|
@vinilage I will merge once I have your approval for the release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
MDB_IMAGE_TYPEenvironment variable was originally used by the community operator but became orphaned after the MEKO/MCO merge. The community operator now usesMDB_COMMUNITY_IMAGE_TYPEinstead. It was used by the enterprise operator until around October 2024.Commit removing its usage: https://github.com/10gen/ops-manager-kubernetes/commit/e0127188c835c2bb374488533950824180faf490
And then, used by the community operator only.
This PR removes the unused variable from:
As a follow up of this ticket, I created WRITING-34891, to come up with an engineering proposal, which will propose a proper solution for configurable UBI base image selection.
Note: I added the documentation changes required in the Jira ticket, for public doc.
For example we mention it here: https://www.mongodb.com/docs/kubernetes/current/reference/kubectl-operator-settings/
Proof of Work
make precommitChecklist
skip-changeloglabel if not needed