Skip to content

Traits management update #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NicolasAnquetil merged 2 commits into from
Feb 14, 2025
Merged

Traits management update #23

NicolasAnquetil merged 2 commits into from
Feb 14, 2025

Conversation

@ClotildeToullec
Copy link
Member

@ClotildeToullec ClotildeToullec commented Feb 14, 2025

  • FM3Trait has now the #users property, and not #owner. Same for the opposite in FM3Type.
  • All traits should be computed to generate all appropriate properties in a class but only local traits for the class definition and imports, to avoid redundancy.
  • modify iteration in computeAllTraits() to avoid conflicts.

@ClotildeToullec
Modify traits management.
dadbe1c 
- Compute all traits to generate properties (attributes & accessors).
- Only get traits from the class when writing the imports.
This is to avoid redundancy in classes definition but still get all correct properties.
@ClotildeToullec
FM3Trait: the property is now #users, not #owner.
eb0e24c
@NicolasAnquetil NicolasAnquetil merged commit 56001be into master Feb 14, 2025
1 check passed
@NicolasAnquetil NicolasAnquetil deleted the traits-update branch February 14, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasAnquetil NicolasAnquetil Awaiting requested review from NicolasAnquetil

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ClotildeToullec @NicolasAnquetil