Feat/blue X pa with on-demand reallocation - #108
Conversation
…g liquidity; refund unspent msg.value" This reverts commit 446f114.
💡 Codex Reviewbundles/src/blue/BlueBundlesV1.sol Line 78 in 2339786 If an allocator lowers any native penalty after this transaction is constructed, bundles/src/blue/BlueBundlesV1.sol Line 67 in 2339786 In the checked AGENTS.md reference: AGENTS.md:L5-L6 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b508adefed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SafeTransferLib.safeTransfer(marketParams.loanToken, referralFeeRecipient, referralFeeAssets); | ||
| } | ||
| SafeTransferLib.safeTransfer(marketParams.loanToken, msg.sender, borrowAssets - referralFeeAssets); | ||
| refundNative(unspentNativePenalty); |
There was a problem hiding this comment.
Pass reallocations to the NoResidue rules
When the Certora job runs, supplyCollateralAndBorrowPreservesBalance in certora/specs/NoResidue.spec:129 still invokes this entry point without its PublicReallocation[] argument; the withdraw rule at line 116 has the same stale arity. These calls cannot resolve to the Solidity ABI signatures, so NoResidue.conf errors before verifying this new native-refund path. Add reallocation arrays to both rules and pass them into the calls.
AGENTS.md reference: AGENTS.md:L77-L77
Useful? React with 👍 / 👎.
alternate approach where reallocations are executed only as necessitated by the blue operation