Skip to content

fix(auth): point email app download buttons at the Bitly link - #21018

Merged
vbudhram merged 1 commit into
mainfrom
fxa-14115
Aug 14, 2026
Merged

fix(auth): point email app download buttons at the Bitly link#21018
vbudhram merged 1 commit into
mainfrom
fxa-14115

Conversation

@vbudhram

@vbudhram vbudhram commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Because

  • The Adjust tracker behind the app store badges in FxA emails stopped recording in March, so download clicks from email are no longer attributed.
  • The reporter asked for every email that shows those badges, not the welcome email alone.

This pull request

  • Sets the androidUrl and iosUrl defaults in packages/fxa-auth-server/config/index.ts to https://mzl.la/email-appdownload.
  • Both values feed the shared appBadges partial, so four templates pick up the new link with no template edits: postVerify, passwordResetAccountRecovery, cadReminderFirst, cadReminderSecond.
  • Leaves downloadSubscription alone. It falls back to appStoreLink and playStoreLink from per-product subscription metadata, which are store links for a subscribed app rather than the generic Firefox badges.

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-14115

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on: packages/fxa-auth-server/config/index.ts, the smtp.androidUrl and smtp.iosUrl defaults.
  • Risky or complex parts: neither key has an env: entry. Please confirm stage and prod config does not pin these values, or the change will not take effect there.

Screenshots (Optional)

Not applicable, no user interface change.

Other information (Optional)

  • Attribution trade-off: the old URLs carried campaign=fxa-conf-email plus adgroup=android or adgroup=ios, so clicks split by platform and by campaign. One Bitly link for both badges reports a single total with no split. The reporter chose the single link.
  • fxa-admin-server keeps its own androidUrl and iosUrl defaults on the old Adjust URLs. Its templates do not render appBadges, so nothing there is user-visible. Left out of scope.

@vbudhram
vbudhram requested a review from a team as a code owner August 12, 2026 20:20
@vbudhram vbudhram added the auto label Aug 12, 2026
@vbudhram

Copy link
Copy Markdown
Contributor Author

Blocked on merge order.

15 checks pass. The one failure is Pair2/Supplicant/TimeoutAndCancel — the timeout variant's expected text omits the <b> markup its own Fluent message carries. Pre-existing on main; this PR only touches fxa-auth-server/config/index.ts and cannot reach it.

Fix is already in #21016. Merge that first, then rerun here. Not duplicating the one-line fix, since identical changes in two open PRs conflict on the second merge.

@LZoog LZoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ because I see Ipsita thumbsed up this comment in the ticket:

One reviewer call: the old URLs split attribution by platform and campaign; one Bitly link reports a single total.

This doesn't have env vars where this could drift across env vars so 👍

@vbudhram
vbudhram merged commit 5c6c007 into main Aug 14, 2026
20 checks passed
@vbudhram
vbudhram deleted the fxa-14115 branch August 14, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants